UIK 5640/radio cards - #3101
Open
slizhevskyv-semrush wants to merge 7 commits into
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| | `Tab` | When focus moves to the `RadioCards`, it moves to the active `RadioCards.Item`. | | ||
| | `Left Arrow` , `Right Arrow` | Set `checked` value to the next/previous button in the group. If focus is on the last/first button, moves focus to the first/last button respectively. | | ||
|
|
||
| See detailed information about the keyboard support for clickable elements in the [Keyboard control guide](/core-principles/a11y/a11y-keyboard#any-other-controls-filtertrigger-pills-tabline-etc). |
There was a problem hiding this comment.
🚫 [vale] <DevDocs.Names> reported by reviewdog 🐶
Use 'A11y' or 'A11Y' instead of 'a11y'.
Suggested change
| See detailed information about the keyboard support for clickable elements in the [Keyboard control guide](/core-principles/a11y/a11y-keyboard#any-other-controls-filtertrigger-pills-tabline-etc). | |
| See detailed information about the keyboard support for clickable elements in the [Keyboard control guide](/core-principles/A11y/a11y-keyboard#any-other-controls-filtertrigger-pills-tabline-etc). |
Suggested change
| See detailed information about the keyboard support for clickable elements in the [Keyboard control guide](/core-principles/a11y/a11y-keyboard#any-other-controls-filtertrigger-pills-tabline-etc). | |
| See detailed information about the keyboard support for clickable elements in the [Keyboard control guide](/core-principles/A11Y/a11y-keyboard#any-other-controls-filtertrigger-pills-tabline-etc). |
| --- | ||
| title: Radio Cards | ||
| fileSource: radio-cards | ||
| tabs: Design('radio-cards'), A11y('radio-cards-a11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') |
There was a problem hiding this comment.
🚫 [vale] <DevDocs.Names> reported by reviewdog 🐶
Use 'A11y' or 'A11Y' instead of 'a11y'.
Suggested change
| tabs: Design('radio-cards'), A11y('radio-cards-a11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') | |
| tabs: Design('radio-cards'), A11y('radio-cards-A11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') |
Suggested change
| tabs: Design('radio-cards'), A11y('radio-cards-a11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') | |
| tabs: Design('radio-cards'), A11y('radio-cards-A11Y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') |
| --- | ||
| title: Radio Cards | ||
| fileSource: radio-cards | ||
| tabs: Design('radio-cards'), A11y('radio-cards-a11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') |
There was a problem hiding this comment.
🚫 [vale] <DevDocs.Names> reported by reviewdog 🐶
Use 'A11y' or 'A11Y' instead of 'a11y'.
Suggested change
| tabs: Design('radio-cards'), A11y('radio-cards-a11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') | |
| tabs: Design('radio-cards'), A11y('radio-cards-A11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') |
Suggested change
| tabs: Design('radio-cards'), A11y('radio-cards-a11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') | |
| tabs: Design('radio-cards'), A11y('radio-cards-A11Y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') |
| --- | ||
| title: Radio Cards | ||
| fileSource: radio-cards | ||
| tabs: Design('radio-cards'), A11y('radio-cards-a11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') |
There was a problem hiding this comment.
🚫 [vale] <DevDocs.Names> reported by reviewdog 🐶
Use 'A11y' or 'A11Y' instead of 'a11y'.
Suggested change
| tabs: Design('radio-cards'), A11y('radio-cards-a11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') | |
| tabs: Design('radio-cards'), A11y('radio-cards-A11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') |
Suggested change
| tabs: Design('radio-cards'), A11y('radio-cards-a11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') | |
| tabs: Design('radio-cards'), A11y('radio-cards-A11Y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') |
| --- | ||
| title: Radio Cards | ||
| fileSource: radio-cards | ||
| tabs: Design('radio-cards'), A11y('radio-cards-a11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') |
There was a problem hiding this comment.
🚫 [vale] <DevDocs.Names> reported by reviewdog 🐶
Use 'A11y' or 'A11Y' instead of 'a11y'.
Suggested change
| tabs: Design('radio-cards'), A11y('radio-cards-a11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') | |
| tabs: Design('radio-cards'), A11y('radio-cards-A11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') |
Suggested change
| tabs: Design('radio-cards'), A11y('radio-cards-a11y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') | |
| tabs: Design('radio-cards'), A11y('radio-cards-A11Y'), API('radio-cards-api'), Examples('radio-cards-code'), Changelog('radio-cards-changelog') |
slizhevskyv-semrush
requested review from
Valeria-Zimnitskaya,
ilyabrower and
sheila-semrush
August 4, 2026 10:22
ilyabrower
reviewed
Aug 4, 2026
| aria-disabled={disabled} | ||
| aria-checked={checked} | ||
| > | ||
| {advancedMode |
Contributor
There was a problem hiding this comment.
do we really need advanced mode here?)
Contributor
Author
There was a problem hiding this comment.
idk, since it's called as radio-cards I cannot guarantee that left or right addon will be filled with the correct content. That is why I decided to expand the component to advanced mode. idk :) we could discuss it deeper :)
| }, | ||
| "dependencies": { | ||
| "@semcore/typography": "^17.2.1" | ||
| }, |
Contributor
There was a problem hiding this comment.
You should add peerDeps. Core and base-components, I think
ilyabrower
approved these changes
Aug 10, 2026
| <> | ||
| <RadioCards.Item.Header> | ||
| {iconAddon && <RadioCards.Item.Header.LeftAddon>{iconAddon}</RadioCards.Item.Header.LeftAddon>} | ||
| {value && <RadioCards.Item.Header.Text>{value}</RadioCards.Item.Header.Text>} |
Contributor
There was a problem hiding this comment.
let's use here textHeader, value will be some hidden value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Added new
RadioCardscomponent.How has this been tested?
I've added unit test.
Screenshots (if appropriate):
Types of changes
Checklist: