Skip to content

[UIK-5667][skeleton, spin-container, spin] redesign - #3106

Open
ilyabrower wants to merge 6 commits into
UIK-5351/add-more-variables-to-themefrom
UIK-5667/spin-redesign
Open

[UIK-5667][skeleton, spin-container, spin] redesign#3106
ilyabrower wants to merge 6 commits into
UIK-5351/add-more-variables-to-themefrom
UIK-5667/spin-redesign

Conversation

@ilyabrower

Copy link
Copy Markdown
Contributor

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

type Ctx = {
gradientUrl: string;
/**
* Flag for render the Skeleton in the dark theme.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Flag for render the Skeleton in the dark theme.
* Flag for render the Skeleton on darker backgrounds.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but on the other hand, I think we agreed to just rename the themes here. Dark to invert and invert to default

Comment thread semcore/spin/src/Spin.tsx
fill='none'
strokeWidth={strokeWidth}
strokeLinecap='round'
pathLength={100}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added pathLength={100} for more straightforward calculations (also updated numbers in the animation styles to match this pathLength)

width: 20px;
height: 20px;
SCircle {
animation-name: stretch;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed dasharray & dashoffset from the default style because I want the Spin to look like a simple circle when animations are disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment