[UIK-5667][skeleton, spin-container, spin] redesign - #3106
Open
ilyabrower wants to merge 6 commits into
Open
Conversation
| type Ctx = { | ||
| gradientUrl: string; | ||
| /** | ||
| * Flag for render the Skeleton in the dark theme. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Flag for render the Skeleton in the dark theme. | |
| * Flag for render the Skeleton on darker backgrounds. |
Contributor
There was a problem hiding this comment.
but on the other hand, I think we agreed to just rename the themes here. Dark to invert and invert to default
slizhevskyv-semrush
approved these changes
Aug 10, 2026
| fill='none' | ||
| strokeWidth={strokeWidth} | ||
| strokeLinecap='round' | ||
| pathLength={100} |
Contributor
There was a problem hiding this comment.
I added pathLength={100} for more straightforward calculations (also updated numbers in the animation styles to match this pathLength)
| width: 20px; | ||
| height: 20px; | ||
| SCircle { | ||
| animation-name: stretch; |
Contributor
There was a problem hiding this comment.
I removed dasharray & dashoffset from the default style because I want the Spin to look like a simple circle when animations are disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: