Settings page: lang-ref heading + Premium upgrade CTA (Lite 2.0.4 prep) - #4
Open
senlin wants to merge 11 commits into
Open
Settings page: lang-ref heading + Premium upgrade CTA (Lite 2.0.4 prep)#4senlin wants to merge 11 commits into
senlin wants to merge 11 commits into
Conversation
… primary folder cell
Add .so_qmp_table class to the settings table and update CSS to increase header padding and emphasize the language reference row (larger font and weight). Reorder table headers and adjust cell structure (move header row above the lang-ref row, add an empty leading cell, and change colspan) to improve column alignment and presentation. Files: css/admin.css, src/Admin/SettingsPage.php.
…_qmp_table, add sidebar top margin
Tweak admin UI: CSS changes set a fixed 150px width for form table headers, make language-ref rows italic, and push the Premium sidebar down (margin-top 170px). PHP changes add an i18n 'Languages' column header and shorten 'Primary Language'/'Secondary Language' to 'Primary'/'Secondary' in the settings table (using esc_html_e).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings page rework for Lite 2.0.4 (branch
feature/settings-page-lite-2.0.4).Changes
1.
images/folderimages/.gitkeep,images/qml-free-large.png,images/qml-premium-large.png.qml-free-32.png,qml-premium-24.png,qml-premium-64.png,qml-premium-32.png) are referenced by filename only — not yet committed (to be generated).2.
src/Admin/SettingsPage.php—render()rewriteqml-free-32.png) via.so_qmp-page-title..so_qmp-content-with-sidebarwrapping.so_qmp-main-content+ a persistent.so_qmp-premium-sidebarPremium panel (logo, feature list, Get Premium CTA).form-table:.so_qmp-premium-teaser(logo + copy + Get Premium button) — replaces the old absolute-positioned 'Coming Soon' overlay that bled outside its container.colspantable row (.so_qmp-lang-ref-row)..so_qmp-na).plugin_dir_url( dirname( dirname( __FILE__ ) ) ) . 'images/'.so_qmp_number_of_languagesremains disabled in Lite.3.
css/admin.css— appended styles for the title logo, two-column layout, Premium sidebar, inline teaser, and the N/A cell / lang-ref row. Existing rules unchanged (old.so_qmp-premium-overlayrules left in place, now unused/harmless).Validation
php -lpasses onSettingsPage.php.render()executed against stubbed WordPress functions — renders without errors and emits all expected markup (sidebar, teaser, N/A cell, lang-ref row, page-mapping rows, image references).