Add a test for the defmt feature - #577
Open
TDecking wants to merge 1 commit into
Open
Conversation
Collaborator
|
is it worth it to upgrade to 1.88 just for those kinds of let expressions?? two version = three months, which puts us at a +2.5 month surplus from the original baseline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #475.
This test does a lot less than one might expect because
defmttakes up a lot of responsibility for correctness.The official documentation (https://defmt.ferrous-systems.com/faq-for-library-authors) recommends to use QEMU to
run a cross compiled binary for testing. I decided not to do that. Instead, I used a crate for connecting
defmtwith thelogcrate, which is IMHO a better apprach.Because
defmtis designed for embedded systems, this test won't run on either Windows or with miri. Windows is not supported bydefmt, and the program tries to access certain linker sections of its binary, which runs into issues with miri's isolation.