BTAdapter: clear discovery state on reset - #7
Open
vkolotov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reset()takes the controller down and back up, which clearsHCIHandler::currentScanType, butBTAdapter's owncurrentMetaScanTypeanddiscovery_policywere left untouched. A discovery session that was runningbefore the reset therefore appeared still active afterwards, while the controller
was no longer scanning.
discovery_serviceand setDiscoveryPolicy::AUTO_OFFbefore the reset,so the keep-alive worker cannot race it.
currentMetaScanTypeand emitdiscoveringChangedonce the controllerreached the reset state, so listeners observe the implicit stop.
discovery contract intact.
DBTAdapter.reset()clears the Java-side scan cache for the same reason.A new discovery session must be started explicitly after a reset.