lib/tz.c: tz(): Some improvements (default to UTC) - #1678
Open
alejandro-colomar wants to merge 8 commits into
Open
lib/tz.c: tz(): Some improvements (default to UTC)#1678alejandro-colomar wants to merge 8 commits into
alejandro-colomar wants to merge 8 commits into
Conversation
alejandro-colomar
changed the title
CST6CDT seems to be a deprecated name, and also it feels weird to have an offset by default. The world defaults to UTC these days for most stuff. Signed-off-by: Alejandro Colomar <alx@kernel.org>
We set 'fp' unconditionally with the result of fopen(3). Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
'buf' instead of 'tzbuf', since it's a more common name. 'fname' => 'path', since it represents a path name, and not just a file component. Signed-off-by: Alejandro Colomar <alx@kernel.org>
While at it, remove unused includes. Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default to UTC. Also, improve readability. Also, improve error handling.