Remove sx:negated from ShExR - #88
Open
ericprud wants to merge 1 commit into
Open
Conversation
The ShEx 2.0 draft `!` operator on TripleConstraint, removed from the language in Nov 2016 (shexTest 224c610, spec d3f882d) over shexSpec/shex#11 and replaced by {0,0} and ShapeNot. fe51e15 copied it back into ShExR from ShExJ.jsg seven weeks later; e01f012 cleaned the grammar in 2020 but not ShExR. It was never in http://www.w3.org/ns/shex#, is not in the spec, and the ShExC parser has no `!` rule, so nothing could produce it. Matches shexTest 265f62f. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShExR.shexhere is a copy of shexTest'sdoc/ShExR.shex, and it still carriessx:negated.negatedwas the ShEx 2.0 draft's!operator on TripleConstraint. It was removed from the language in November 2016 — shexTest224c610"- negated", andd3f882d"- negation" in this repo, which stripped thenegated:BOOL?slot from the TripleConstraint production along with thesenseFlagsprose and the"negated": trueexamples — over the semantics problem in shexSpec/shex#11, and replaced by{0,0}cardinality andShapeNot.Seven weeks later, shexTest
fe51e15("~ aligned with ShExJ.jsg") copied it back intoShExR.shexfromdoc/ShExJ.jsg, which had not been cleaned up yet.e01f012("TripleConstraint -= negated:BOOL") finally dropped it from the grammar in 2020 but left ShExR alone, so the RDF rendering kept a term the JSON rendering had just deleted.It has never been in
http://www.w3.org/ns/shex, is not in this spec's abstract syntax, and the ShExC parser has no!rule — so nothing can produce it and nothing consumes it. No test fixture anywhere carries ashex:negatedtriple.Matches shexTest #73 (which also removes it from
ShExR.{ttl,json,ntriples},doc/ShExV.jsgand a danglingschemas/meta.ttlreference) and shex.js489a1a75.ShExR.shexstill parses.🤖 Generated with Claude Code
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Aug 6, 2026, 6:34 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build bikeshed/ReSpec specs
🔗 Related URL
Error output:
This seems to be an issue with the Spec Generator service. PR Preview doesn't manage this service and so has no control over it. If you've identified an issue with it, you can report the issue to the maintainers of Spec Generator directly. Please be courteous. Thank you!
If you don't have enough information above to solve the error by yourself or if the issue doesn't seem related to Spec Generator, you can file an issue with PR Preview.