FAFF-481: headless subscription-seat handle (seat_token_env) + consumer wiring - #513
Merged
alechill merged 2 commits intoAug 2, 2026
Conversation
alechill
force-pushed
the
faff-481-wire-subscription-seat-auth-into-engine-call-config
branch
from
August 2, 2026 15:53
1da534a to
fa30377
Compare
alechill
deleted the
faff-481-wire-subscription-seat-auth-into-engine-call-config
branch
August 2, 2026 15:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements ADR-0092 Decision 4 (FAFF-481): the optional headless seat handle for
auth: subscription-seat, so a non-codex subscription seat can authenticate off the interactive harness.backends.js— new optionalseat_token_env(subscription-seat only); validation admits it on a seat, rejects it onapi-key/none, andapi_key_envstays a seat-forbidden api-key handle;resolveTokenSourceresolves the handle env (else ambient-session);portableMatrixAdmitsadmits a handle-carrying seat on any harness (the ADR-0076 amendment) while a handle-less anthropic seat stays interactive-only and codex stays any-harness.config.js—resolveEngineForLanecarriesauth+seatTokenEnvonto the resolved record.engine.js(openai family) andreview-call.mjs(openaiBearer+ the FAFF-210 anthropicx-api-keyadaptor) resolve the token via the resolver's rule; an unset handle →auth-failedpre-call. Codex (engine-codex.js, ambientcodex login) unchanged.Config carries an env var name, never a secret (ADR-0067). Existing handle-absent configs resolve byte-for-byte as today.
Acceptance Criteria
seat_token_envadded (seat-only): schema, normalize, validation —backends.js; selftests greenresolveTokenSourceresolves handle env vs ambient-session —backends.jsportableMatrixAdmitsadmits handle-carrying seat headlessly; handle-less anthropic interactive-only; codex unchanged —backends.jsengine.js,review-call.mjsReview
Two-phase, both clean: structural (security-sensitive auth review) + adversarial second opinion (NVIDIA GLM-5.2,
observation: no findings). Full verdict on FAFF-481.Validation
faff backends --selftest,faff engine --selftest— passnode --test(backends/engine/config/adversarial) — 356 tests passfaff validate-adapters(LINT) — passCloses FAFF-481.