fix(streamer): prevent skipPath from over-matching .git prefix

[mohit-bhandari45]

Changes

This fixes a bug where skipPath in the streamer would unintentionally drop files that shared the .git prefix, such as .gitignore, .gitmodules, and .gitattributes. The matcher now checks the source-relative path and only excludes a path component named .git.

The relative-path comparison also preserves Windows UNC paths correctly.

Additionally, it normalizes cross-platform paths using filepath.ToSlash prior to string matching to safeguard against path comparison bugs when the CLI is run on Windows machines.

Related Issue

Fixes #408

Type of PR

/kind bug

Submitter Checklist

• Includes tests if functionality changed/was added
• Kind label has been set
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Fixed a bug in the `shp` CLI local source streamer where files prefixed with `.git` (such as `.gitignore`, `.gitmodules`, and `.gitattributes`) were incorrectly omitted from the build context.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign saschaschwarze0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kaizakin]

/ok-to-test

[kaizakin]

@mohit-bhandari45 Thanks for your contribution

apparently there's something wrong with the release notes
can you check that with the PR template and fix it

[Copilot]

🟡 Changes recommended

UNC path handling and test boundary assertions must be corrected before approval.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

pkg/shp/streamer/tar.go:34

• This blank line contains trailing whitespace, so the changed file is not gofmt-clean. Please remove it to keep the Go source formatter-compliant.

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Balanced

[SaschaSchwarze0]

@mohit-bhandari45 may you check the Copilot comments whether they are of relevance. Also, make sure to sign your commits, otherwise we cannot accept them. https://github.com/shipwright-io/cli/pull/409/checks?check_run_id=100509499395

[mohit-bhandari45]

@SaschaSchwarze0 Updates are done and commits are signed.
@kaizakin can you check one more time?

[Copilot]

🟡 Changes recommended

The nested .git filtering and invalid archive member handling must be corrected.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

pkg/shp/streamer/tar_test.go:42

• The claimed Windows/UNC behavior is not exercised here. filepath.ToSlash uses the host OS separator, and the unit workflow runs only on Ubuntu (.github/workflows/unit.yaml:16), so this remains a no-op in CI and cannot catch regressions in Windows filepath.Rel or separator handling. Please add Windows-specific coverage (or extract a platform-independent matcher that can be tested with Windows-style paths).

		cleanName := filepath.ToSlash(name)

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Balanced

[mohit-bhandari45]

@kaizakin @SaschaSchwarze0 Done

[kaizakin]

Looks good to me

Thanks for your conrtibution @mohit-bhandari45

/lgtm