Skip to content

fix: bypasses system shell completely #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivarm merged 2 commits into from
Jul 10, 2026
Merged

fix: bypasses system shell completely #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4688129
fix: bypasses system shell completely
shivarm Jul 10, 2026
fb08d12
remove unused import
shivarm Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions src/scanner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import path from 'node:path';
import { fileURLToPath } from 'node:url';
import fg from 'fast-glob';
import ignore from 'ignore';
import { execSync } from 'node:child_process';
import { execFileSync } from 'node:child_process';
import { styleText } from 'node:util';
import { findUnusedModules } from './unusedModuleDetector.js';
import { matchWithTimeout } from './safeRegex.js';
Expand Down Expand Up @@ -55,16 +55,24 @@ function listFiles({ staged, ignoreFiles } = {}) {
ig.add(ignoreFiles);
}

if (staged) {
// Use git to list staged files
try {
const out = execSync('git diff --name-only --staged', { encoding: 'utf8' });
const files = out.split(/\r?\n/).map(s => s.trim()).filter(Boolean);
return files.filter(f => fs.existsSync(f) && !ig.ignores(f));
} catch (err) {
throw new Error('Failed to get staged files. Are you in a git repo?');
}
}
if (staged) {
try {
// Bypasses system shell parsing entirely, preventing binary injection hooks
const out = execFileSync("git", ["diff", "--name-only", "--staged"], {
encoding: "utf8",
shell: false,
windowsHide: true,
timeout: 5000, // Prevents the tool from hanging if a Git process gets locked
});
const files = out
.split(/\r?\n/)
.map((s) => s.trim())
.filter(Boolean);
return files.filter((f) => fs.existsSync(f) && !ig.ignores(f));
} catch (err) {
throw new Error("Failed to get staged files securely. Are you in a git repo?");
}
}

// otherwise use fast-glob across repo files (text files)
const entries = fg.sync(['**/*.*', '**/*'], { dot: true, onlyFiles: true, ignore: ['**/node_modules/**', '**/.git/**'] });
Expand Down