[claude] Enable selecting a local or remote lexicon (Platform.Bible) - #2585
Draft
myieye wants to merge 4 commits into
Draft
[claude] Enable selecting a local or remote lexicon (Platform.Bible)#2585myieye wants to merge 4 commits into
myieye wants to merge 4 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
💻 FW Lite
…nsion Replace the combo box with a searchable picker for choosing a project's lexicon: pick a local one, or download-and-select a remote (Lexbox) one. Local lexicons are filtered to the project's vernacular language with a show-all escape hatch; the current lexicon is marked with a "Current" badge and kept visible regardless of language (along with any applied this session). Supports deleting a local copy and creating a new lexicon. Reorders the FwHeadless already-downloaded short-circuit so re-selecting a downloaded project doesn't re-hit the server. Toward #2461. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
myieye
force-pushed
the
issue-2461-select-remote-project
branch
from
August 20, 2026 05:44
9bdd4cb to
5493fa2
Compare
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
…te/effects Nothing downstream is memoized, so the picker's useCallback wrappers only added dependency-array bookkeeping (and stale-closure risk); make them plain functions (keeping the one that's a DOM ref). In the web view, fold the three lockstep language-filter states into one object, and split the combined open-log/fetch effect so toggling "show all" no longer re-logs the open and re-fetches the (language-independent) remote list. Behaviour unchanged; verified select->save end-to-end. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Pull the ~95-line row renderer into a presentational LexiconRow (fed its identity/selection/deletability as props, so it imports no picker internals) and the delete-confirmation Alert into DeleteConfirm. The picker drops from 627 to ~470 lines; behaviour unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…dy errors - Delete now works for any local CRDT lexicon, not only downloaded copies: the guard drops to `crdt` (FwData still refused, current lexicon still blocked), and DeleteConfirm warns "permanently deletes … can't be undone" when there's no server to re-download from. - Drop the fragile `userFacingError` regex; show `getErrorMessage(e)` directly (the JSON-RPC prefix only appears on rare unexpected command rejections). - Standardize the resolve-project timeout to 5 min (matches sign-in/download). - Trim over-long doc comments across the changeset; align stray logs to getErrorMessage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Claude, autonomous]
Resolves #2461.
Searchable picker for choosing a project's lexicon — local, or remote (Lexbox):
Draft — before ready-for-review:
lexicon.changeLexiconswitcher.