Skip to content

[claude] Stop generating metrics in .NET - #2631

Open
myieye wants to merge 2 commits into
claude/otel-drop-duplicate-metrics-datasetfrom
claude/otel-drop-dotnet-metrics
Open

[claude] Stop generating metrics in .NET#2631
myieye wants to merge 2 commits into
claude/otel-drop-duplicate-metrics-datasetfrom
claude/otel-drop-dotnet-metrics

Conversation

@myieye

@myieye myieye commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

[Claude, autonomous]

Stacked on #2628 — nothing exports metrics any more, so stop generating them. The one custom meter, api.login-attempts, was created but never incremented, so no dashboard loses data.

  • The gha and local-dev collector overrides still patched service.pipelines.metrics. With Stop exporting metrics from the collector #2628 removing that pipeline from the base config, the merge leaves it with exporters and no receivers and the collector refuses to start. Stop exporting metrics from the collector #2628's own CI couldn't catch it: otel/** is in no workflow's path filter.
  • UseOtlpExporter() "automatically enables logging, metrics, and tracing", so FwHeadless kept a MeterProvider posting empty metric batches every minute. Swapped for signal-specific exporters (verified: no MeterProvider in DI, tracer still there).
  • Follow-up, not in scope here: hg's Java agent (deployment/base/hg-deployment.yaml) still exports metrics to the collector and wants OTEL_METRICS_EXPORTER=none.

🤖 Generated with Claude Code

myieye and others added 2 commits September 4, 2026 17:31
Nothing exports them since the collector's metrics pipeline was removed,
so the meters and their instrumentation packages are just overhead.

Also drops the metrics pipeline from the gha and local-dev collector
overrides: with no metrics pipeline in the base config to merge into,
they'd leave the collector with a receiver-less pipeline and it would
refuse to start.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
It "automatically enables logging, metrics, and tracing", so FwHeadless
kept a MeterProvider and posted an empty /v1/metrics batch every minute
at a collector that no longer has a metrics pipeline. Signal-specific
exporters instead; the two can't be mixed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions github-actions Bot added the 📦 Lexbox issues related to any server side code, fw-headless included label Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: a554be3e-8709-48c5-ae61-56444ccb183c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@argos-ci

argos-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Sep 4, 2026, 4:21 PM
e2e (Inspect) ✅ No changes detected - Sep 4, 2026, 4:29 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 Lexbox issues related to any server side code, fw-headless included

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant