[claude] Stop generating metrics in .NET - #2631
Conversation
Nothing exports them since the collector's metrics pipeline was removed, so the meters and their instrumentation packages are just overhead. Also drops the metrics pipeline from the gha and local-dev collector overrides: with no metrics pipeline in the base config to merge into, they'd leave the collector with a receiver-less pipeline and it would refuse to start. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
It "automatically enables logging, metrics, and tracing", so FwHeadless kept a MeterProvider and posted an empty /v1/metrics batch every minute at a collector that no longer has a metrics pipeline. Signal-specific exporters instead; the two can't be mixed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
[Claude, autonomous]
Stacked on #2628 — nothing exports metrics any more, so stop generating them. The one custom meter,
api.login-attempts, was created but never incremented, so no dashboard loses data.service.pipelines.metrics. With Stop exporting metrics from the collector #2628 removing that pipeline from the base config, the merge leaves it with exporters and no receivers and the collector refuses to start. Stop exporting metrics from the collector #2628's own CI couldn't catch it:otel/**is in no workflow's path filter.UseOtlpExporter()"automatically enables logging, metrics, and tracing", so FwHeadless kept a MeterProvider posting empty metric batches every minute. Swapped for signal-specific exporters (verified: noMeterProviderin DI, tracer still there).deployment/base/hg-deployment.yaml) still exports metrics to the collector and wantsOTEL_METRICS_EXPORTER=none.🤖 Generated with Claude Code