Skip to content

Create a distinct row for each rendering of a term#310

Merged
Enkidu93 merged 3 commits into
masterfrom
fix_multirendering_term_parsing
Jun 10, 2025
Merged

Create a distinct row for each rendering of a term#310
Enkidu93 merged 3 commits into
masterfrom
fix_multirendering_term_parsing

Conversation

@Enkidu93

@Enkidu93 Enkidu93 commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@Enkidu93
Enkidu93 requested a review from ddaspit June 9, 2025 21:08

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it fixes an issue where the glosses returned from ZipParatextProjectTermsParser were getting misinterpreted as tokens. Is that correct?

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@Enkidu93

Enkidu93 commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator Author

This looks like it fixes an issue where the glosses returned from ZipParatextProjectTermsParser were getting misinterpreted as tokens. Is that correct?

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

Yes! That's right. Sorry - I sent a message in Slack, but there was more space between putting in the PR and sending the message than anticipated.

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@Enkidu93
Enkidu93 force-pushed the fix_multirendering_term_parsing branch from 016338e to ff8b54e Compare June 10, 2025 13:22
@codecov-commenter

codecov-commenter commented Jun 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.76%. Comparing base (2184367) to head (34f0259).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   70.75%   70.76%           
=======================================
  Files         390      390           
  Lines       32721    32723    +2     
  Branches     4605     4605           
=======================================
+ Hits        23153    23155    +2     
  Misses       8510     8510           
  Partials     1058     1058           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93
Enkidu93 merged commit 5e916a5 into master Jun 10, 2025
3 of 4 checks passed
@Enkidu93
Enkidu93 deleted the fix_multirendering_term_parsing branch June 10, 2025 16:28
Enkidu93 added a commit to sillsdev/serval that referenced this pull request Aug 11, 2025
Enkidu93 added a commit to sillsdev/serval that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants