WIP no_std - #477
Draft
Ygg01 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to use simd_json in
no_stdenvironments. So we introduceno_stdand refactor a bit.What went wrong?
Just about everything.
value_traitcrate is std onlyIt uses
io: Writethroughout to define bounds. Which is fine, but without it being no_std this crate has no chance to bestdLots of
println!macrosYeah, those don't work if you don't have output.
Hard to separate
no_stdandstdboundary.I honestly prefer multiple crates per workspace and then deal with all crates in a single folder.
Next moves
Best way to approach IMO is:
value_traitcrate in.a. Add
stdfeature (possibly breaking change) tovalue_traitb. In
stdfeature usestd::io, otherwise useembedded_iocratec. bump major version and publish.
iocomponents to a crate that imports theno_stdversionsimd-lite-corecrate is my goto, but i can settle forFix #92 when it actually lands.