Recover not completed archives after restart.#8
Open
iparask wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archiving is asynchronous and tracks it as an in-memory
concurrent.futures.Future. That future is the problem: it lives in a in-process queue. If the server dies mid-copy the archives is not completed. Currently nothing re-picks it up and the archive is silently dropped.This PR introduces a recovery logic that is run once at startup. This checks if the archive was actually completed or not and updates the DB accordingly. Any archive that is not marked completed, but consumed returns in a non-consumed state and the consumption threads picks it up.
This PR also fixes a postgres bug that did not allow a postgres integration to run.
🤖 Assisted by Claude Opus 4.8