Drop Ruby 3.2 support; the floor is now 3.3 - #216
Merged
Conversation
Ruby 3.2 reached end of life on 2026-03-31, and the git-sourced openai dev dependency (#207, #212) now requires >= 3.3.0, so bundle install on the 3.2 CI job fails whenever setup-ruby's cache misses and Bundler has to resolve for real. Rather than special-casing that one dependency and that one job, raise required_ruby_version to >= 3.3.0 and test only the supported floor. .rubocop.yml already targeted 3.3.5. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #214, which kept the 3.2 job alive by gating the OpenAI SDK dev dependency behind a Ruby-version check and disabling gem caching on that one job.
Problem
bundle installfails on the Ruby 3.2 matrix job whenever Bundler has to resolve for real (i.e. wheneversetup-ruby's cache misses, as it does on any PR that touches a rubygems-sourced gem — #213 is the current example):#207 and #212 moved the git-sourced
openaidev dependency to revisions where upstream raised itsrequired_ruby_versionto>= 3.3.0, while the gemspec here still declared>= 3.2.0and CI still tested that floor.Fix
Drop 3.2 instead of working around it. Ruby 3.2 has been EOL since 2026-03-31,
.rubocop.ymlalready setsTargetRubyVersion: 3.3.5, and a Gemfile/CI workaround for one dependency would have had to be maintained indefinitely.ruby-mcp-client.gemspec:required_ruby_versionis now>= 3.3.0..github/workflows/ci.yml: the two-entry matrix becomes a singleTest (Ruby 3.3, floor)job, mirroring the shape of the 4.0.6 job. Gem caching stays on for both.README.md: the Requirements section states the new floor.No library code changes. No
Gemfile.lockchanges.Breaking change
This is a breaking change for anyone installing the gem on Ruby 3.2 — RubyGems will refuse the next released version there.
CHANGELOG.mdis written at release time in this repo, so the next release's Breaking Changes section should carry an entry for this.Verification
bundle installleavesGemfile.lockbyte-identical; RuboCop clean; 1701 examples, 0 failures.Gemfile.lockbyte-identical afterbundle install, so the CI job's cached lockfile replay and a real resolve agree; RuboCop clean; 1701 examples, 0 failures.test (3.2)/test (3.3)check names, so the rename is safe.Once merged,
@dependabot rebaseon #213 should turn it green.🤖 Generated with Claude Code