fix: preserve Unicode surrogate pairs during slugification - #217
Open
ilovesugarr wants to merge 1 commit into
Open
fix: preserve Unicode surrogate pairs during slugification#217ilovesugarr wants to merge 1 commit into
ilovesugarr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Unicode surrogate pair handling by replacing
split('')withArray.from()when iterating normalized strings.Motivation
JavaScript strings are UTF-16 encoded, and
split('')splits non-BMP characters such as emojis into separate surrogate halves. This preventsslugify.extend()from matching characters like emojis and may corrupt their handling.Implementation
Use
Array.from(string.normalize())so iteration happens by Unicode code points instead of UTF-16 code units.Testing
Added tests covering:
slugify.extend()mappings with non-BMP characters