Remove inference agent

[andre-senna]

WIP towards #1208

Removes Inference agent

[coderabbitai]

• Removed the Inference agent implementation, public classes, Bazel targets, startup scripts, documentation, service-bus command, and helper-factory integration.
• Removed inference-specific configuration and static initialization. This reduces startup work and avoids inference allocations on active paths. No new hot-path allocations are introduced.
• The main correctness risk is an incomplete removal that leaves stale INFERENCE_AGENT or ServiceBus::INFERENCE references. The change also removes inference request timeout, abort, validation, and error-handling paths.
• Removed unit and integration tests with the agent. The behavior removal has matching test-target deletions, but no replacement tests verify that remaining agents, service commands, and factories still work without inference support.

Walkthrough

Changes

The Inference Agent implementation, public headers, Bazel targets, runtime integrations, service command, startup scripts, documentation, and tests were removed. Remaining agent behavior and configuration were preserved.

Inference Agent removal

Layer / File(s)	Summary
Inference Agent implementation and build targets src/agents/inference_agent/*, src/BUILD	Removed the inference agent classes, request processing, context handling, proxy logic, iterator, validator, Bazel declarations, and shared-library dependency.
Runtime and service integration cleanup src/main/bus_node.cc, src/main/helpers/*, src/service_bus/*, src/scripts/run_agents.sh, src/scripts/integration_test_setup.sh, src/scripts/setup_inference_toy_problem.sh	Removed processor and proxy creation, helper mappings, service command registration, startup variables, and the inference toy-problem setup script.
Documentation and test cleanup src/agents/context_broker/README.md, src/agents/inference_agent/README.md, src/main/README.md, src/tests/cpp/*, src/tests/integration/cpp/*	Removed inference usage documentation and C++ unit and integration test targets and sources.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: ccgsnet

---

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

• Ignore

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Tests For Behavior Changes	❌ Error	Production behavior changes remove the inference service, factories, and agent, while all inference tests are deleted; the description gives no test-omission justification.	Add or update tests that verify inference-agent removal and unsupported commands, or explain in the PR description why test updates are intentionally omitted.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the removal of the Inference agent.
Description check	✅ Passed	The description directly states that the pull request removes the Inference agent and references the related issue.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch senna-1208-0

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/main/helpers/Helper.cc (1)

268-268: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Update the C++ tests for the changed unknown-service behavior.

Add or update a *_test.cc under src/tests/cpp/. Cover an unsupported processor string and verify that lookup returns ProcessorType::UNKNOWN, required arguments are empty for both caller types, and generic help does not list the unsupported service. Remove obsolete inference-agent-specific tests instead of adding tests that retain the removed identifier.

As per coding guidelines, test updates are required when production code under src/ changes behavior. As per path instructions, keep the inference-agent removal narrowly scoped and remove related tests with the feature.

Also applies to: 283-283, 333-333

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/helpers/Helper.cc` at line 268, Update the relevant C++ test file
under src/tests/cpp to cover an unsupported processor string: assert lookup
returns ProcessorType::UNKNOWN, required arguments are empty for both caller
types, and generic help omits the unsupported service. Remove obsolete
inference-agent-specific tests and references so the inference-agent removal
remains narrowly scoped.

Sources: Coding guidelines, Path instructions

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@src/main/helpers/Helper.cc`:
- Line 268: Update the relevant C++ test file under src/tests/cpp to cover an
unsupported processor string: assert lookup returns ProcessorType::UNKNOWN,
required arguments are empty for both caller types, and generic help omits the
unsupported service. Remove obsolete inference-agent-specific tests and
references so the inference-agent removal remains narrowly scoped.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: bb9fd491-2fd6-49f2-a384-c6dd2a521c03

📥 Commits

Reviewing files that changed from the base of the PR and between 1be99f7 and 1bc8daa.

📒 Files selected for processing (32)

• src/BUILD
• src/agents/context_broker/README.md
• src/agents/inference_agent/BUILD
• src/agents/inference_agent/InferenceAgent.cc
• src/agents/inference_agent/InferenceAgent.h
• src/agents/inference_agent/InferenceContext.cc
• src/agents/inference_agent/InferenceContext.h
• src/agents/inference_agent/InferenceIterator.h
• src/agents/inference_agent/InferenceProcessor.cc
• src/agents/inference_agent/InferenceProcessor.h
• src/agents/inference_agent/InferenceProxy.cc
• src/agents/inference_agent/InferenceProxy.h
• src/agents/inference_agent/InferenceRequest.cc
• src/agents/inference_agent/InferenceRequest.h
• src/agents/inference_agent/InferenceRequestValidator.h
• src/agents/inference_agent/README.md
• src/main/README.md
• src/main/bus_node.cc
• src/main/helpers/BUILD
• src/main/helpers/Helper.cc
• src/main/helpers/Helper.h
• src/main/helpers/ProcessorFactory.h
• src/main/helpers/ProxyFactory.h
• src/scripts/integration_test_setup.sh
• src/scripts/run_agents.sh
• src/scripts/setup_inference_toy_problem.sh
• src/service_bus/ServiceBus.cc
• src/service_bus/ServiceBus.h
• src/tests/cpp/BUILD
• src/tests/cpp/inference_agent_test.cc
• src/tests/integration/cpp/BUILD
• src/tests/integration/cpp/inference_integration_test.cc

💤 Files with no reviewable changes (30)

• src/agents/inference_agent/InferenceProcessor.h
• src/main/helpers/BUILD
• src/agents/inference_agent/InferenceRequestValidator.h
• src/agents/inference_agent/InferenceRequest.h
• src/agents/context_broker/README.md
• src/agents/inference_agent/InferenceAgent.h
• src/agents/inference_agent/InferenceContext.cc
• src/main/bus_node.cc
• src/BUILD
• src/service_bus/ServiceBus.h
• src/agents/inference_agent/InferenceAgent.cc
• src/agents/inference_agent/InferenceProxy.cc
• src/agents/inference_agent/BUILD
• src/main/README.md
• src/service_bus/ServiceBus.cc
• src/scripts/setup_inference_toy_problem.sh
• src/main/helpers/ProcessorFactory.h
• src/agents/inference_agent/InferenceIterator.h
• src/agents/inference_agent/README.md
• src/main/helpers/Helper.h
• src/agents/inference_agent/InferenceProcessor.cc
• src/main/helpers/ProxyFactory.h
• src/tests/integration/cpp/inference_integration_test.cc
• src/agents/inference_agent/InferenceRequest.cc
• src/tests/cpp/inference_agent_test.cc
• src/agents/inference_agent/InferenceContext.h
• src/tests/cpp/BUILD
• src/agents/inference_agent/InferenceProxy.h
• src/scripts/run_agents.sh
• src/tests/integration/cpp/BUILD