refactor: dependency update and comply with stricter linting - #46
Open
sirtimbly wants to merge 4 commits into
Open
refactor: dependency update and comply with stricter linting#46sirtimbly wants to merge 4 commits into
sirtimbly wants to merge 4 commits into
Conversation
Upgrading some package versions including the XO linter led to a re-evaluation of some code. So types have been moved to another file, and some signatures were updated. The registeredField type no longer needs a generic type, it is assumed to be string. All interfaces were renamed to remove the I. Cyclical dependency fixed. BREAKING CHANGE: Interface names changed. RegisteredField no longer has generic type argument, it's always a string.
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
===========================================
+ Coverage 68.86% 80.00% +11.13%
===========================================
Files 3 3
Lines 106 105 -1
Branches 25 27 +2
===========================================
+ Hits 73 84 +11
+ Misses 19 9 -10
+ Partials 14 12 -2
Continue to review full report at Codecov.
|
added 3 commits
March 15, 2022 12:52
Upgrading some package versions including the XO linter led to a re-evaluation of some code. So types have been moved to another file, and some signatures were updated. The registeredField type no longer needs a generic type, it is assumed to be string. All interfaces were renamed to remove the I. Cyclical dependency fixed. BREAKING CHANGE: Interface names changed. RegisteredField no longer has generic type argument, it's always a string.
…nto cleanup-2022-types-etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading some package versions including the XO linter led to a
re-evaluation of some code. So types have been moved to another file,
and some signatures were updated. The registeredField type no longer
needs a generic type, it is assumed to be string. All interfaces were
renamed to remove the
I. Cyclical dependency fixed.BREAKING CHANGE: Interface names changed. RegisteredField no longer has generic type argument, it's
always a string.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Other information: