Fix the OCFD cut list and the inverted-L / vertical sketch - #12
Merged
Conversation
Continuing the multiband build-sheet audit, the off-center-fed dipole and the inverted-L each had a problem. OCFD: the cut list showed one continuous wire, hiding the off-centre feed that is the whole point of the design. It now lists the two unequal legs a builder actually cuts off the centre balun — "Short leg" and "Long leg" — from the feed_fraction split (handling a bent OCFD via the path length too). Inverted-L / vertical sketch: the projection chooser picked the plan view (radials spread widest there), which collapses the vertical radiator — and an inverted-L's riser + bent top — to a point. geometry_sketch now forces a side elevation for any VerticalModel, so the vertical structure (and the L's Γ shape) shows above the ground line. Tests: OCFD short/long legs at the one-third / two-thirds split; vertical and inverted-L sketches use a side elevation. Suite 519 -> 521. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Continuing the multiband build-sheet audit (#10, #11), I checked the OCFD and inverted-L. Each had a problem.
OCFD (Windom) — feed position was missing
The cut list showed one continuous 20.5 m wire, hiding the off-center feed that is the design. An OCFD is built as a short leg + long leg off a center balun, so those leg lengths are what the builder needs. Now:
(Handles a bent OCFD via the path length too.)
Inverted-L / vertical — sketch hid the vertical structure
The projection chooser picked the plan view (the radials spread widest there), which collapses the vertical radiator — and an inverted-L's riser + bent top — to a point.
geometry_sketchnow forces a side elevation for anyVerticalModel, so the vertical structure (and the L's Γ shape) shows above the ground line. This also improves the plain-vertical sketch (was a top-down radial star that didn't show the radiator at all).Tests
tests/test_buildsheet.py+tests/test_sketch.py(+2): OCFD short/long legs at the one-third/two-thirds split; vertical and inverted-L sketches use a side elevation. Existing sketch/buildsheet/ocfd/vertical tests pass unchanged. Suite 519 → 521, green locally.Multiband build-sheet audit — now complete
fan dipole (#10), trapped dipole/vertical + vertical radials (#11), and now OCFD + inverted-L. Every multiband/multi-wire antenna's cut list and sketch has been checked.
🤖 Generated with Claude Code