Point the Basic-Mode Sweep tab at Advanced Mode - #9
Merged
Conversation
The Sweep results tab is always visible, but the controls to run a sweep
(start/stop/steps + the Run-sweep button) live in the Advanced-Mode-only box,
hidden by default. So a Basic-Mode user saw a Sweep tab whose placeholder said
"Run a frequency sweep..." with no button anywhere — making the feature look
broken ("sweep doesn't do anything").
The sweep is an Advanced feature by design (spec §8), so rather than move the
controls, the empty tab now tells the truth: in Basic Mode it reads "The
frequency sweep is an Advanced-Mode feature. Use View -> Promote to Advanced
Mode to run one." Promoting drops the hint back to the normal ready-to-run
prompt. SweepView.clear() gained an optional message argument to carry it.
Tests: the Basic-Mode tab names Advanced Mode; promoting clears the hint.
Suite 512 -> 514.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A user reported "sweep doesn't do anything." It does — the solver, plot, and handler all work and are tested. The issue is pure UX: the Sweep results tab is always visible, but the controls to run a sweep (start/stop/steps spinboxes + "Run sweep" button) live in the Advanced-Mode-only box that's hidden by default (
_advanced_sweep_box,setVisible(False)).So in Basic Mode you see a Sweep tab whose placeholder says "Run a frequency sweep…" — with no button anywhere to do it. The tab looks broken.
Fix
The frequency sweep is an Advanced-Mode feature by design (spec §8), so rather than move the controls, the empty tab now tells the truth:
SweepView.clear()gained an optionalmessageargument;MainWindowsets the hint at startup (the app begins in Basic Mode) and clears it back to the default in both promote paths (both early-return when already advanced, so a shown sweep is never wiped).Tests
tests/test_sweep.py(+2): the Basic-Mode tab names Advanced Mode; promoting drops the hint. Suite 512 → 514, green locally.For reference, the resulting placeholder text:
The frequency sweep is an Advanced-Mode feature.\nUse View → Promote to Advanced Mode to run one.Run a frequency sweep to see SWR across the band.🤖 Generated with Claude Code