Skip to content

FIX Handle lazy import failures during trusted type discovery in skops.io - #528

Merged
adrinjalali merged 2 commits into
mainfrom
copilot/bug-import-transformer-before-skops
Jul 31, 2026
Merged

FIX Handle lazy import failures during trusted type discovery in skops.io#528
adrinjalali merged 2 commits into
mainfrom
copilot/bug-import-transformer-before-skops

Conversation

Copilot AI commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Importing transformers before skops.io could raise ModuleNotFoundError when transformers lazy attributes attempted to import optional vision dependencies (e.g. torchvision) during skops trusted-type enumeration. This PR makes module discovery tolerant of those lazy import failures.

  • Root-cause containment in module resolution

    • Updated skops/io/_utils.py::whichmodule to ignore ImportError in addition to AttributeError while scanning sys.modules.
    • This prevents optional-dependency import failures from aborting skops.io import-time trusted-type collection.
  • Regression coverage for lazy-module behavior

    • Added a focused test in skops/io/tests/test_utils.py that injects a lazy module into sys.modules whose __getattr__ raises ModuleNotFoundError.
    • Verifies whichmodule(...) safely falls back instead of propagating the error.
  • Behavioral change (minimal and targeted)

# before
except AttributeError:
    pass

# after
except (AttributeError, ImportError):
    pass

Copilot AI changed the title [WIP] Fix ModuleNotFoundError when importing transformer before skops Handle lazy import failures during trusted type discovery in skops.io Jul 31, 2026
Copilot AI requested a review from adrinjalali July 31, 2026 09:55
@adrinjalali
adrinjalali marked this pull request as ready for review July 31, 2026 11:55
@adrinjalali adrinjalali changed the title Handle lazy import failures during trusted type discovery in skops.io FIX Handle lazy import failures during trusted type discovery in skops.io Jul 31, 2026
@adrinjalali
adrinjalali merged commit 2788e18 into main Jul 31, 2026
57 checks passed
@adrinjalali
adrinjalali deleted the copilot/bug-import-transformer-before-skops branch July 31, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: import transformer before skops causes ModuleNotFoundError

2 participants