Conversation
…P client NotifyConfigChanged fires the opt-out beacon from a goroutine; several telemetry tests build the Service as a bare literal with no client, so under an unlucky shuffle order the goroutine reached http.Client.Do on a nil receiver and took the whole test binary down (Unit Tests (shuffle) on #1285, seed 1789588229734730758). Refuse to send instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deploying mcpproxy-docs with
|
| Latest commit: |
43f7508
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4c2f8064.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-telemetry-optout-nil-cli.mcpproxy-docs.pages.dev |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 35144470954 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Unit Tests (shuffle)on #1285 died ininternal/telemetrywith a nil-pointer panic in a goroutine —net/http.(*Client).do(0x0, …)fromService.SendOptOutBeacon, spawned fire-and-forget byNotifyConfigChanged. Several telemetry tests build theServiceas a bare literal with noclient; under an unlucky shuffle order the beacon goroutine outlives its test, passes the env/semver/anon-id guards and dereferences the nil client, taking the whole test binary down. Unrelated to the PR it hit (H0 touches no telemetry code).What
SendOptOutBeaconreturns an error when no client is configured instead of dereferencing it. Production always constructs the client (telemetry.go:570), so behaviour there is unchanged.The seed (
-shuffle=1789588229734730758) does not reproduce locally (timing-dependent), but the stack pins the cause.🤖 Generated with Claude Code