Skip to content

[CCIP-13349] Datastore qualifier - #540

Merged
AmrMohamedRezk merged 1 commit into
developfrom
datastore_qualifier
Sep 4, 2026
Merged

[CCIP-13349] Datastore qualifier#540
AmrMohamedRezk merged 1 commit into
developfrom
datastore_qualifier

Conversation

@AmrMohamedRezk

Copy link
Copy Markdown
Contributor

This PR does the following:

  • Migrate Aptos CCIP address persistence to record-at-site datastore writes.
  • Use explicit semantic qualifiers for singleton, MCMS, token, and token-pool addresses.
  • Add preflight validation for datastore key collisions and missing qualifiers.
  • Preserve datastore metadata and ensure fresh changeset output overlays existing state correctly.
  • Remove legacy address-book-to-datastore population helpers.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

👋 AmrMohamedRezk, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@RodrigoAD RodrigoAD left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All look good, thanks @AmrMohamedRezk 👍

@AmrMohamedRezk
AmrMohamedRezk merged commit 04a21d0 into develop Sep 4, 2026
25 checks passed
@AmrMohamedRezk
AmrMohamedRezk deleted the datastore_qualifier branch September 4, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants