Skip to content

use forge std from npm #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RensR merged 9 commits into from
Aug 21, 2026
Merged

use forge std from npm #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f2a186d
use forge std from npm
RensR Aug 21, 2026
9b2d676
delete vendor version
RensR Aug 21, 2026
480aec0
fix snapshot all
RensR Aug 21, 2026
e972622
bump forge-std to 1.16.2 & snap
RensR Aug 21, 2026
b733cca
use `--isolate` in gas snap
RensR Aug 21, 2026
c2a9dd0
same for cre
RensR Aug 21, 2026
10b3751
don't run with prod=true for tests
RensR Aug 21, 2026
8142106
undo isolate
RensR Aug 21, 2026
0349bc3
fix vrf version
RensR Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/solidity-foundry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ jobs:
|| needs.changes.outputs.non_src_changes == 'true' }}
uses: ./.github/actions/setup-nodejs
with:
prod: "true"
prod: "false"

@RensR RensR Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed because forge-std is a dev dependency


- name: Install Foundry
if:
Expand Down
2 changes: 1 addition & 1 deletion contracts/GNUmakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ALL_FOUNDRY_PRODUCTS contains a list of all products that have a foundry
# profile defined and use the Foundry snapshots.
ALL_FOUNDRY_PRODUCTS = automation-cre keystone l2ep llo-feeds operatorforwarder payments shared workflow data-feeds

@RensR RensR Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have been moved out a while ago, fixing tech debt

ALL_FOUNDRY_PRODUCTS = automation-cre l2ep llo-feeds operatorforwarder payments shared data-feeds
Comment thread
RensR marked this conversation as resolved.

# To make a snapshot for a specific product, either set the `FOUNDRY_PROFILE` env var
# or call the target with `FOUNDRY_PROFILE=product`
Expand Down
22 changes: 11 additions & 11 deletions contracts/cre/gas-snapshots/dev.gas-snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,20 @@ MessageEmitter_BasicTest:test_EmitMessage_MultipleAddressesSameBlock() (gas: 117
MessageEmitter_BasicTest:test_EmitMessage_SucceedsInNextBlock() (gas: 90723)
MessageEmitter_BasicTest:test_GetMessage_Succeeds_WhenExists() (gas: 62952)
MessageEmitter_BasicTest:test_TypeAndVersion() (gas: 9616)
MockKeystoneForwarder_BasicTest:test_GetTransmissionId_MatchesManual() (gas: 9375)
MockKeystoneForwarder_BasicTest:test_GetTransmissionInfo_NotAttempted_And_GetTransmitter_Zero() (gas: 19659)
MockKeystoneForwarder_BasicTest:test_IsForwarder_SelfTrue_AddRemove() (gas: 32448)
MockKeystoneForwarder_BasicTest:test_Route_Direct_Failure() (gas: 48805)
MockKeystoneForwarder_BasicTest:test_Route_Direct_Success() (gas: 51514)
MockKeystoneForwarder_BasicTest:test_GetTransmissionId_MatchesManual() (gas: 6207)
MockKeystoneForwarder_BasicTest:test_GetTransmissionInfo_NotAttempted_And_GetTransmitter_Zero() (gas: 13763)
MockKeystoneForwarder_BasicTest:test_IsForwarder_SelfTrue_AddRemove() (gas: 29399)
MockKeystoneForwarder_BasicTest:test_Route_Direct_Failure() (gas: 43060)
MockKeystoneForwarder_BasicTest:test_Route_Direct_Success() (gas: 45763)
MockKeystoneForwarder_BasicTest:test_TypeAndVersion() (gas: 9731)
ReserveManagerTest:testOnReportUpdatesStateAndEmitsEvent() (gas: 81553)
ReserveManagerTest:testSupportsInterface() (gas: 12071)
ReserveManagerTest:testOnReportUpdatesStateAndEmitsEvent() (gas: 80867)
ReserveManagerTest:testSupportsInterface() (gas: 7547)
ShardConfigTest:testConstructor_RevertZeroShardCount() (gas: 58081)
ShardConfigTest:testConstructor_Success() (gas: 13715)
ShardConfigTest:testGetDesiredShardCount() (gas: 10390)
ShardConfigTest:testOwnershipTransfer() (gas: 29818)
ShardConfigTest:testConstructor_Success() (gas: 10526)
ShardConfigTest:testGetDesiredShardCount() (gas: 7538)
ShardConfigTest:testOwnershipTransfer() (gas: 29274)
ShardConfigTest:testSetDesiredShardCount_EmitsEvent() (gas: 17833)
ShardConfigTest:testSetDesiredShardCount_RevertNotOwner() (gas: 10795)
ShardConfigTest:testSetDesiredShardCount_RevertZeroCount() (gas: 10648)
ShardConfigTest:testSetDesiredShardCount_Success() (gas: 18700)
ShardConfigTest:testSetDesiredShardCount_Success() (gas: 15505)
ShardConfigTest:testTypeAndVersion() (gas: 9705)
184 changes: 92 additions & 92 deletions contracts/cre/gas-snapshots/v1.gas-snapshot
View file
Open in desktop

Large diffs are not rendered by default.

370 changes: 185 additions & 185 deletions contracts/cre/gas-snapshots/v2.gas-snapshot
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions contracts/cre/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
"@openzeppelin/contracts": "4.9.6"
}
},

"devDependencies": {
"solhint": "^6.2.4",
"solhint-plugin-chainlink-solidity": "github:smartcontractkit/chainlink-solhint-rules#v1.2.1"
"solhint-plugin-chainlink-solidity": "github:smartcontractkit/chainlink-solhint-rules#v1.2.1",
"forge-std": "github:foundry-rs/forge-std#v1.16.2"
},
"dependencies": {
"@openzeppelin/contracts-4.8.3": "npm:@openzeppelin/contracts@4.8.3",
Expand Down
9 changes: 9 additions & 0 deletions contracts/cre/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion contracts/cre/remappings.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
forge-std/=node_modules/@chainlink/contracts/src/v0.8/vendor/forge-std/src/
forge-std/=node_modules/forge-std/src/
@chainlink/contracts/=node_modules/@chainlink/contracts/

@openzeppelin/contracts@4.8.3=node_modules/@openzeppelin/contracts-4.8.3
Expand Down
68 changes: 34 additions & 34 deletions contracts/gas-snapshots/data-feeds.gas-snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
BundleAggregatorProxyTest:test_aggregator() (gas: 12620)
BundleAggregatorProxyTest:test_bundleDecimals() (gas: 19152)
BundleAggregatorProxyTest:test_aggregator() (gas: 9785)
BundleAggregatorProxyTest:test_bundleDecimals() (gas: 16300)
BundleAggregatorProxyTest:test_confirmAggregatorRevertNotProposed() (gas: 13155)
BundleAggregatorProxyTest:test_confirmAggregatorSuccess() (gas: 32435)
BundleAggregatorProxyTest:test_description() (gas: 20305)
BundleAggregatorProxyTest:test_latestBundle() (gas: 19795)
BundleAggregatorProxyTest:test_latestBundleTimestamp() (gas: 18092)
BundleAggregatorProxyTest:test_proposeAggregator() (gas: 41274)
BundleAggregatorProxyTest:test_version() (gas: 13639)
BundleAggregatorProxyTest:test_latestBundle() (gas: 16946)
BundleAggregatorProxyTest:test_latestBundleTimestamp() (gas: 15240)
BundleAggregatorProxyTest:test_proposeAggregator() (gas: 40942)
BundleAggregatorProxyTest:test_version() (gas: 10787)
DataFeedsCacheGasTest:test_bundleDecimals_proxy_gas() (gas: 22286)
DataFeedsCacheGasTest:test_decimals_proxy_gas() (gas: 16912)
DataFeedsCacheGasTest:test_description_proxy_gas() (gas: 20706)
Expand Down Expand Up @@ -35,41 +35,41 @@ DataFeedsCacheGasTest:test_write_setDecimalFeedConfigs_1_gas() (gas: 219180)
DataFeedsCacheGasTest:test_write_setDecimalFeedConfigs_5_gas() (gas: 980459)
DataFeedsCacheGasTest:test_write_setDecimalFeedConfigs_with_delete_1_gas() (gas: 74514)
DataFeedsCacheGasTest:test_write_setDecimalFeedConfigs_with_delete_5_gas() (gas: 297007)
DataFeedsCacheTest:testFuzzy_getDataType(bytes16,uint256) (runs: 256, μ: 9492, ~: 9492)
DataFeedsCacheTest:testFuzzy_getDataType(bytes16,uint256) (runs: 256, μ: 9146, ~: 9146)
DataFeedsCacheTest:testFuzzy_getDataTypeRevertOutOfBound(bytes16,uint256) (runs: 256, μ: 9269, ~: 9269)
DataFeedsCacheTest:testFuzzy_recoverTokensERC20Success(uint256) (runs: 256, μ: 77076, ~: 77076)
DataFeedsCacheTest:testFuzzy_recoverTokensNativeSuccess(uint256) (runs: 256, μ: 49092, ~: 49092)
DataFeedsCacheTest:test_bundleDecimals() (gas: 282593)
DataFeedsCacheTest:test_decimals() (gas: 221706)
DataFeedsCacheTest:testFuzzy_recoverTokensERC20Success(uint256) (runs: 256, μ: 76409, ~: 76409)
DataFeedsCacheTest:testFuzzy_recoverTokensNativeSuccess(uint256) (runs: 256, μ: 48096, ~: 48096)
DataFeedsCacheTest:test_bundleDecimals() (gas: 281597)
DataFeedsCacheTest:test_decimals() (gas: 221374)
DataFeedsCacheTest:test_description() (gas: 224355)
DataFeedsCacheTest:test_feedCanBeWrittenToByMultipleWorkflows() (gas: 219534)
DataFeedsCacheTest:test_getDataIdForProxy() (gas: 15208)
DataFeedsCacheTest:test_getDataType() (gas: 8885)
DataFeedsCacheTest:test_getFeedMetadata() (gas: 268408)
DataFeedsCacheTest:test_feedCanBeWrittenToByMultipleWorkflows() (gas: 216360)
DataFeedsCacheTest:test_getDataIdForProxy() (gas: 12359)
DataFeedsCacheTest:test_getDataType() (gas: 6039)
DataFeedsCacheTest:test_getFeedMetadata() (gas: 259937)
DataFeedsCacheTest:test_getFeedMetadataRevertFeedNotConfigured() (gas: 13418)
DataFeedsCacheTest:test_getLatestAnswer1() (gas: 307893)
DataFeedsCacheTest:test_getLatestAnswer2() (gas: 578516)
DataFeedsCacheTest:test_getLatestBundle1() (gas: 410713)
DataFeedsCacheTest:test_getLatestBundle2() (gas: 781449)
DataFeedsCacheTest:test_getLatestByFeedId() (gas: 317993)
DataFeedsCacheTest:test_getWorkflowMetaData() (gas: 10183)
DataFeedsCacheTest:test_isFeedAdmin() (gas: 14294)
DataFeedsCacheTest:test_latestAnswer1() (gas: 314079)
DataFeedsCacheTest:test_latestAnswer2() (gas: 589227)
DataFeedsCacheTest:test_latestBundle1() (gas: 420308)
DataFeedsCacheTest:test_latestBundle2() (gas: 798325)
DataFeedsCacheTest:test_getLatestAnswer1() (gas: 307550)
DataFeedsCacheTest:test_getLatestAnswer2() (gas: 577830)
DataFeedsCacheTest:test_getLatestBundle1() (gas: 409053)
DataFeedsCacheTest:test_getLatestBundle2() (gas: 778129)
DataFeedsCacheTest:test_getLatestByFeedId() (gas: 315658)
DataFeedsCacheTest:test_getWorkflowMetaData() (gas: 7015)
DataFeedsCacheTest:test_isFeedAdmin() (gas: 11114)
DataFeedsCacheTest:test_latestAnswer1() (gas: 313736)
DataFeedsCacheTest:test_latestAnswer2() (gas: 588541)
DataFeedsCacheTest:test_latestBundle1() (gas: 418316)
DataFeedsCacheTest:test_latestBundle2() (gas: 795005)
DataFeedsCacheTest:test_onReportInvalidPermission() (gas: 675249)
DataFeedsCacheTest:test_onReportRevertInvalidWorkflowName() (gas: 252344)
DataFeedsCacheTest:test_onReportRevertInvalidWorkflowOwner() (gas: 252374)
DataFeedsCacheTest:test_onReportStaleBundleReport() (gas: 815321)
DataFeedsCacheTest:test_onReportStaleDecimalReport() (gas: 635670)
DataFeedsCacheTest:test_onReportSuccess_BundleReportLength1() (gas: 402709)
DataFeedsCacheTest:test_onReportSuccess_BundleReportLength2() (gas: 765894)
DataFeedsCacheTest:test_onReportSuccess_DecimalReportLength1() (gas: 310079)
DataFeedsCacheTest:test_onReportSuccess_DecimalReportLength1() (gas: 309736)
DataFeedsCacheTest:test_onReportSuccess_DecimalReportLength2() (gas: 579838)
DataFeedsCacheTest:test_onReportSuccess_EmptyBundleReport() (gas: 251195)
DataFeedsCacheTest:test_onReportSuccess_EmptyDecimalReport() (gas: 241310)
DataFeedsCacheTest:test_onReportSuccess_EmptyReport() (gas: 221781)
DataFeedsCacheTest:test_onReportSuccess_EmptyDecimalReport() (gas: 239595)
DataFeedsCacheTest:test_onReportSuccess_EmptyReport() (gas: 221438)
DataFeedsCacheTest:test_recoverTokensERC20RevertNoBalance() (gas: 19928)
DataFeedsCacheTest:test_recoverTokensNativeRevertNoBalance() (gas: 11489)
DataFeedsCacheTest:test_recoverTokensRevertUnauthorized() (gas: 13353)
Expand All @@ -78,20 +78,20 @@ DataFeedsCacheTest:test_removeDataIdMappingsForProxiesSuccess_and_call_decimals(
DataFeedsCacheTest:test_removeFeedAdminSuccess() (gas: 27000)
DataFeedsCacheTest:test_removeFeedsRevertInvalidSender() (gas: 12166)
DataFeedsCacheTest:test_removeFeedsRevertNotConfiguredFeed() (gas: 20120)
DataFeedsCacheTest:test_removeFeedsSuccess() (gas: 193844)
DataFeedsCacheTest:test_removeFeedsSuccess() (gas: 193040)
DataFeedsCacheTest:test_setBundleFeedConfigsRevertInvalidConfigsLengthDecimals() (gas: 32379)
DataFeedsCacheTest:test_setBundleFeedConfigs_setAgainWithClear() (gas: 961624)
DataFeedsCacheTest:test_setDecimalFeedConfigs_setAgainWithClear() (gas: 744323)
DataFeedsCacheTest:test_setBundleFeedConfigs_setAgainWithClear() (gas: 949953)
DataFeedsCacheTest:test_setDecimalFeedConfigs_setAgainWithClear() (gas: 735308)
DataFeedsCacheTest:test_setFeedAdminRevertZeroAddress() (gas: 11343)
DataFeedsCacheTest:test_setFeedConfigsRevertEmptyConfig() (gas: 55621)
DataFeedsCacheTest:test_setFeedConfigsRevertInvalidConfigsLengthDescriptions() (gas: 48286)
DataFeedsCacheTest:test_setFeedConfigsRevertInvalidWorkflowMetadata() (gas: 94046)
DataFeedsCacheTest:test_setFeedConfigsRevertUnauthorizedFeedAdmin() (gas: 43047)
DataFeedsCacheTest:test_setFeedConfigsRevertZeroDataId() (gas: 43199)
DataFeedsCacheTest:test_setFeedConfigsSuccess() (gas: 220704)
DataFeedsCacheTest:test_supportsInterface() (gas: 8637)
DataFeedsCacheTest:test_supportsInterface() (gas: 5794)
DataFeedsCacheTest:test_updateDataIdMappingsForProxiesRevertInvalidLengths() (gas: 12232)
DataFeedsCacheTest:test_updateDataIdMappingsForProxiesRevertUnauthorizedOwner() (gas: 13158)
DataFeedsCacheTest:test_updateDataIdMappingsForProxiesSuccess() (gas: 21331)
DataFeedsCacheTest:test_updateDataIdMappingsForProxies_and_RevertOnWrongCaller() (gas: 25804)
DataFeedsCacheTest:test_updateDataIdMappingsForProxies_and_call_decimals() (gas: 55086)
DataFeedsCacheTest:test_updateDataIdMappingsForProxies_and_call_decimals() (gas: 53758)
Loading
Loading