Skip to content

chore: implement phase 2 #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Tofel wants to merge 2 commits into from
+1,087 −9
Draft

chore: implement phase 2 #2780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
968efb1
chore: implement phase 2
Tofel Aug 31, 2026
3894d9b
chore: enhance unit tests
Tofel Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions grafana-alertcheck/internal/gate/duration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,17 @@ func TestParsePromDuration(t *testing.T) {

func TestParsePromDuration_Errors(t *testing.T) {
cases := []string{
"5", // bare number, no unit
"-5m", // negative
"5x", // unknown unit
"30m1h", // ascending order (must be descending)
"1h1h", // duplicate unit
"m", // unit with no number
"1.5h", // fractional number not supported by this grammar
"1 h", // whitespace
"300y", // overflows time.Duration (int64 nanoseconds) — must error, not wrap negative
"5", // bare number, no unit
"-5m", // negative
"5x", // unknown unit
"30m1h", // ascending order (must be descending)
"1h1h", // duplicate unit
"m", // unit with no number
"1.5h", // fractional number not supported by this grammar
"1 h", // whitespace
"300y", // overflows time.Duration (int64 nanoseconds) — must error, not wrap negative
"1w2d3h4m5s6ms7us8ns", // too many units
"carrot", // completely invalid
}
for _, in := range cases {
if _, err := ParsePromDuration(in); err == nil {
Expand Down
Loading
Loading