chore: implement phase 3 - #2781
Draft
Tofel wants to merge 2 commits into
Draft
Conversation
📊 API Diff Results
|
Tofel
force-pushed
the
dx-5122-alerts-assertion-p3
branch
from
September 1, 2026 11:25
e0da182 to
df1c958
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p3
branch
from
September 1, 2026 14:18
df1c958 to
96a840d
Compare
Add Resolve() for alert name resolution (uid:/Title/Folder/Title/ Folder/Group/Title forms, UID collapse, no-match suggestions) and the grafana-alertcheck CLI's list subcommand, the first runnable piece of the gate. Incorporates review fixes: reject empty path segments in classifyForm, guard uid: against an empty suffix, scope the no-match rule count and suggestions to supported rule kinds only, and exit 0 on -h/--help.
Tofel
force-pushed
the
dx-5122-alerts-assertion-p3
branch
from
September 2, 2026 09:45
74d5473 to
375b1b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Resolve()for alert name resolution (uid:/Title/Folder/Title/Folder/Group/Title forms, UID collapse, no-match suggestions) and thegrafana-alertcheckCLI's list subcommand, the first runnable piece of the gate.Stack created with GitHub Stacks CLI • Give Feedback 💬