Skip to content

chore: implement phase 8 - #2786

Draft
Tofel wants to merge 2 commits into
dx-5122-alerts-assertion-p7from
dx-5122-alerts-assertion-p8
Draft

chore: implement phase 8#2786
Tofel wants to merge 2 commits into
dx-5122-alerts-assertion-p7from
dx-5122-alerts-assertion-p8

Conversation

@Tofel

@Tofel Tofel commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Invariant defended: H6/H7. The one question: can a violation ever
outrank an unobservable rule, or can a pass happen without
Violations empty and err nil?

Adds classify.go: the pure per-instance classifier (outcome table,
preexisting policy, BadFor) and decide(), the seam combining
proveCoverage with those timelines under one Policy. Consolidates
rule-poll filtering and skew translation onto pollsForRule/runnerTime,
shared with coverage.go.


Stack created with GitHub Stacks CLIGive Feedback 💬

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-testing-framework/grafana-alertcheck

View full report

@Tofel
Tofel force-pushed the dx-5122-alerts-assertion-p8 branch from 83cf391 to dc4fadf Compare September 1, 2026 11:25
@Tofel
Tofel force-pushed the dx-5122-alerts-assertion-p8 branch 2 times, most recently from ee34ac5 to 686ccc2 Compare September 1, 2026 14:46
@Tofel
Tofel force-pushed the dx-5122-alerts-assertion-p8 branch from 686ccc2 to cf2505e Compare September 1, 2026 15:25
@Tofel
Tofel force-pushed the dx-5122-alerts-assertion-p8 branch from cf2505e to 13df605 Compare September 2, 2026 09:45
Invariant defended: H6/H7. The one question: can a violation ever
outrank an unobservable rule, or can a pass happen without
Violations empty and err nil?

Adds classify.go: the pure per-instance classifier (outcome table,
preexisting policy, BadFor) and decide(), the seam combining
proveCoverage with those timelines under one Policy. Consolidates
rule-poll filtering and skew translation onto pollsForRule/runnerTime,
shared with coverage.go.
@Tofel
Tofel force-pushed the dx-5122-alerts-assertion-p8 branch from 13df605 to 97a296f Compare September 2, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant