chore: implement phase 11 - #2789
Draft
Tofel wants to merge 1 commit into
Draft
Conversation
📊 API Diff Results
|
Tofel
force-pushed
the
dx-5122-alerts-assertion-p11
branch
from
September 1, 2026 11:25
658d3de to
ea8e035
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p11
branch
from
September 1, 2026 14:18
ea8e035 to
44ded19
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p11
branch
from
September 1, 2026 14:46
44ded19 to
3efbb2f
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p11
branch
2 times, most recently
from
September 2, 2026 09:45
7a0caf2 to
ceb8796
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p11
branch
from
September 2, 2026 09:57
ceb8796 to
c8f7e00
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p11
branch
from
September 2, 2026 11:05
c8f7e00 to
df94923
Compare
Add coverage.go's declared-KeepLast check (no_data_state/exec_err_state, not just an observed reason) and close the remaining §22 gaps: newly_bad's no-early-exit clock assertion, a recorder-mode gap right after the deploy, a rule's own coverage gap overriding its own recovery, a genuinely skew-discriminating staleness test, exit-2 consequences on two Reason-only coverage tests, and end-to-end checks for log-name collapse, a truncated log, and the real watch-written state histogram.
Tofel
force-pushed
the
dx-5122-alerts-assertion-p11
branch
from
September 2, 2026 11:23
df94923 to
159d0b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add coverage.go's declared-KeepLast check (no_data_state/exec_err_state,
not just an observed reason) and close the remaining §22 gaps: newly_bad's
no-early-exit clock assertion, a recorder-mode gap right after the deploy,
a rule's own coverage gap overriding its own recovery, a genuinely
skew-discriminating staleness test, exit-2 consequences on two
Reason-only coverage tests, and end-to-end checks for log-name
collapse, a truncated log, and the real watch-written state histogram.
Stack created with GitHub Stacks CLI • Give Feedback 💬