DRAFT: refactor discused in #116 - #132
Draft
jakubdomanski wants to merge 29 commits into
Draft
Conversation
Added user configuration handling to the task service and updated task completion logic to preload subtasks.
jakubdomanski
marked this pull request as draft
May 19, 2026 09:58
chore: merge with upstread main
Owner
|
I went through the suggestions quickly @jakubdomanski. Thanks for giving it this much thought. Honestly these seem to be pretty good additions to the repo. I'll take a closer look later and probably create issues and breakdowns. I'm struggling with my own capacity to work on mindloop for the time, but I'm sure breaking these down to finer details will help anyone contribute as well. Or if you'd like you could as well. Thanks again! appreciate it. |
Contributor
Author
|
Sorry for the delay; I've had some stuff on my head that was very important. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS IS DRAFT
Just wanted to show that I'm still working on it; it’s taking a bit longer than expected.
Closes #119, #118, #117
See discussion #116
At time of writing this changes are tested by automatic testing and manually testing the web interface.
TODO:
What was done:
Possible next steps / ideas:
6.1. to make kubernetes deployment easier - all vars in config should be able to overwrite by os.GetEnv()
6.2. user config should be moved to db and edited by user in web/cli/tui
6.3. initialization of the app should not depend on running some magic command in cli - wordpress like configuration in web at first run/login would be nice