chore: [CLI-1758] trigger Endpoint Explorer refresh after releases - #7140
Open
mattdolan-snyk wants to merge 1 commit into
Open
chore: [CLI-1758] trigger Endpoint Explorer refresh after releases#7140mattdolan-snyk wants to merge 1 commit into
mattdolan-snyk wants to merge 1 commit into
Conversation
mattdolan-snyk
marked this pull request as ready for review
August 17, 2026 10:47
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This comment has been minimized.
This comment has been minimized.
mattdolan-snyk
force-pushed
the
codex/endpoint-explorer-release-trigger
branch
from
August 17, 2026 10:48
96f2dcb to
a5ba6d0
Compare
PR Reviewer Guide 🔍
|
mattdolan-snyk
changed the title
mattdolan-snyk
enabled auto-merge
August 17, 2026 11:06
danskmt
reviewed
Aug 24, 2026
| --write-out "%{http_code}" \ | ||
| --silent \ | ||
| --show-error \ | ||
| --output /dev/null \ |
Contributor
There was a problem hiding this comment.
Shouldn't we follow same pattern of trigger_repository_event and output to a file? Then we could have more information about a failure?
danskmt
reviewed
Aug 24, 2026
Comment on lines
+185
to
+189
| response=$(curl \ | ||
| --location \ | ||
| --request POST \ | ||
| --connect-timeout 2 \ | ||
| --max-time 5 \ |
Contributor
There was a problem hiding this comment.
should also include retries, for example--retry 2 --retry-connrefused?
danskmt
reviewed
Aug 24, 2026
| "testing" | ||
| ) | ||
|
|
||
| func TestDistributionTriggersRequestEndpointExplorerRefresh(t *testing.T) { |
Contributor
There was a problem hiding this comment.
I believe you have to plug these tests to run in the CI, e.g. in config.yml, under jobs, under test-go:
- run:
name: Running release script tests
command: make test-release-scripts
danskmt
reviewed
Aug 24, 2026
Comment on lines
+200
to
+208
| if [ "$curl_status" -ne 0 ]; then | ||
| echo "WARNING: Endpoint Explorer $channel refresh dispatch failed (curl exit $curl_status); continuing the CLI release." | ||
| elif [ "$response" != "204" ]; then | ||
| echo "WARNING: Endpoint Explorer $channel refresh was not requested (HTTP $response); continuing the CLI release." | ||
| else | ||
| echo "Endpoint Explorer $channel refresh requested." | ||
| fi | ||
|
|
||
| return 0 |
Contributor
There was a problem hiding this comment.
Should we have a different return value for the "WARNING" logs? Because right now it just logs (and might get lost / nobody sees it), but continues the flow normally in all cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
refresh-cli-data.ymlworkflow with the published channelWhy
The Endpoint Explorer should refresh when a public CLI channel changes, without waiting for the Explorer workflow or making CLI releases depend on Explorer availability.
The dispatch is best-effort. Once GitHub accepts the workflow request, the CLI pipeline does not follow or wait for the Explorer run. If the request cannot be made, the CLI release continues and the existing scheduled/manual Explorer refresh remains available as recovery.
Validation
make formatmake lintgo test ./... -skip TestBuildRecipeUsesGeneratedLSMetadataInLdflagsinrelease-scriptsbash -n release-scripts/trigger-endpoint-explorer-refresh.sh.circleci/config.ymlsnyk/endpoint-binary-explorerworkflow still acceptsworkflow_dispatchwithstableandpreviewchannel inputsThe unmodified
TestBuildRecipeUsesGeneratedLSMetadataInLdflagscurrently fails because its temporary CLI fixture does not include the help Markdown now required by the build recipe; the remaining release-script suite passes.Deployment assumption
HAMMERHEAD_GITHUB_PATmust be able to dispatch Actions workflows insnyk/endpoint-binary-explorer. Missing or insufficient access is intentionally warning-only and does not fail the CLI release.