Skip to content

fix: harden Scoop install in deployment monitor #7183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertolopezlopez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: harden Scoop install in deployment monitor #7183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/deployment-monitor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,10 @@ jobs:
shell: pwsh
run: |
Set-ExecutionPolicy -ExecutionPolicy RemoteSigned -Scope CurrentUser
Invoke-RestMethod -Uri https://get.scoop.sh | Invoke-Expression
Invoke-RestMethod -Uri https://get.scoop.sh -OutFile install-scoop.ps1
if ((Get-Item install-scoop.ps1).Length -lt 1000) { throw "Scoop installer download looks truncated" }

@PeterSchafer PeterSchafer Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Where does 1000 come from? Looks a bit hacky.

@robertolopezlopez robertolopezlopez Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes get.scoop.sh returns error page instead of the installer

& ./install-scoop.ps1
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
scoop bucket add snyk https://github.com/snyk/scoop-snyk
scoop install snyk
- name: Capture version and shasum metadata
Expand Down