Skip to content

test(connectivity): isolate all checker env vars in TestDetectProxyConfig #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rrama wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(connectivity): isolate all checker env vars in TestDetectProxyConfig #676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions pkg/local_workflows/connectivity_check_extension/connectivity/checker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,13 @@ func TestDetectProxyConfig(t *testing.T) {

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Clear all proxy-related environment variables for test isolation
proxyEnvVars := []string{"HTTPS_PROXY", "https_proxy", "HTTP_PROXY", "http_proxy", "NO_PROXY", "no_proxy"}
for _, key := range proxyEnvVars {
t.Setenv(key, "")
// Clear every variable the checker reads, so the host environment
// cannot leak into the result. Derived from envVarSpecs so that
// variables added there stay isolated.
for _, spec := range envVarSpecs {
for _, key := range spec.names {
t.Setenv(key, "")
}
}

// Set test environment
Expand Down