feat(ios): add local image sources and decode-time downsampling - #653
Open
maksg wants to merge 1 commit into
Open
feat(ios): add local image sources and decode-time downsampling#653maksg wants to merge 1 commit into
maksg wants to merge 1 commit into
Conversation
Matches the Android package's LocalImageLoader and inSampleSize downsampling. Non-network image sources now load: file:// URIs (including percent-encoded paths), absolute paths, base64 data: URIs, and bare names resolved as bundled resources with Android's name normalization (lowercase, dash to underscore) so cross-platform markdown resolves on both OSes. Android-only schemes (content://, asset://, res://) log and return nil. All decodes, including network bytes, now go through CGImageSource thumbnailing capped at the screen's pixel width, so large images no longer decode at full size. EXIF orientation is baked in and results carry the screen scale, leaving point-size math unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches the Android package's LocalImageLoader and inSampleSize downsampling. Non-network image sources now load: file:// URIs (including percent-encoded paths), absolute paths, base64 data: URIs, and bare names resolved as bundled resources with Android's name normalization (lowercase, dash to underscore) so cross-platform markdown resolves on both OSes. Android-only schemes (content://, asset://, res://) log and return nil.
All decodes, including network bytes, now go through CGImageSource thumbnailing capped at the screen's pixel width, so large images no longer decode at full size. EXIF orientation is baked in and results carry the screen scale, leaving point-size math unchanged.
What/Why?
Testing
PR Checklist