fix(player): allow YouTube export audio - #103
Open
Jolimunium wants to merge 12 commits into
Open
Conversation
- fall back only when the source has exactly one audio stream - allow audio export from HDR video sources - show clear warnings when sentence audio generation or Anki storage fails
- validate the selected stream before exporting sentence audio - fall back only when FFprobe finds exactly one readable audio stream - distinguish missing, non-audio, and protected stream failures
- distinguish original, MPV playable, and external audio inputs - detect missing audio streams separately from restricted codecs - show source-specific sentence audio export warnings
- retry sentence audio export from MPV's playable source only when the original has no audio stream - preserve safe track mapping and source-specific failure diagnostics
…nce audio Allow media stream signature query parameters (such as `sig`, `signature`, and `signed`) in SceneVideoInputResolver so that direct YouTube stream URLs (googlevideo.com) can be validated and resolved for sentence audio mining. Previously, `sig` was included in SENSITIVE_QUERY_NAMES alongside credential tokens, causing YouTube video inputs to be rejected during request validation with SOURCE_UNAVAILABLE. Separated input validation query names from log redaction query names so that sensitive URL query parameters are still sanitized in logcat and diagnostic logs.
6 tasks
Owner
|
the animated mining will be reworked so if you can fix the conflicts that would be good |
Owner
|
is this still needed with the latest pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When mining sentence audio from YouTube videos using the YouTube Extension, card creation succeeded for stills and text but failed for sentence audio, producing the warning notification: "The selected video source could not be read for sentence audio. The card was created without it."
In addition, diagnostic reporting lacked explicit rejection reason details in UI Toast notifications when input validation failed prior to probe execution.
Result
sig=parameters.This PR builds upon #96