fix(player): Fix delayed and stale subtitle dictionary lookups in the player - #90
Closed
Jolimunium wants to merge 1 commit into
Closed
fix(player): Fix delayed and stale subtitle dictionary lookups in the player#90Jolimunium wants to merge 1 commit into
Jolimunium wants to merge 1 commit into
Conversation
Cancel stale subtitle scene captures when the user selects a new term, preserve the original playback state, and resolve the active anime profile consistently before deciding whether media capture is needed.
Owner
|
this is no longer needed sorry for the trouble |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Subtitle lookup could wait for MPV scene capture before showing the dictionary. A second tap during that capture was ignored, leaving the user waiting on the previous selection.
Changes
Result
A new subtitle selection replaces an in-progress capture instead of being ignored, while dictionary-only profiles avoid unnecessary MPV media capture.