Skip to content

fix(player): Fix delayed and stale subtitle dictionary lookups in the player - #90

Closed
Jolimunium wants to merge 1 commit into
sohilsayed:mainfrom
Jolimunium:fix/player-subtitle-lookup-latency
Closed

fix(player): Fix delayed and stale subtitle dictionary lookups in the player#90
Jolimunium wants to merge 1 commit into
sohilsayed:mainfrom
Jolimunium:fix/player-subtitle-lookup-latency

Conversation

@Jolimunium

Copy link
Copy Markdown
Contributor

Problem

Subtitle lookup could wait for MPV scene capture before showing the dictionary. A second tap during that capture was ignored, leaving the user waiting on the previous selection.

Changes

  • Show the dictionary lookup request before optional scene-media capture completes.
  • Cancel and supersede an active capture when the user taps a different subtitle term.
  • Reject and release stale capture results with a generation check.
  • Preserve the original player pause state across replacement lookups.
  • Resolve dictionary profiles using the current anime ID, source, and language consistently in both player controls and popup.

Result

A new subtitle selection replaces an in-progress capture instead of being ignored, while dictionary-only profiles avoid unnecessary MPV media capture.

Cancel stale subtitle scene captures when the user selects a new term, preserve the original playback state, and resolve the active anime profile consistently before deciding whether media capture is needed.
@sohilsayed

Copy link
Copy Markdown
Owner

this is no longer needed sorry for the trouble

@sohilsayed sohilsayed closed this Aug 3, 2026
@Jolimunium
Jolimunium deleted the fix/player-subtitle-lookup-latency branch August 4, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants