Skip to content

fix(shaders): don't re-convert raw canvas shaders #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiefcll merged 1 commit into from
Jul 2, 2026
Merged

fix(shaders): don't re-convert raw canvas shaders #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/core/elementNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1620,7 +1620,10 @@ export class ElementNode {
}

// Can you put effects on Text nodes? Need to confirm...
if (SHADERS_ENABLED && props.shader && !props.shader.program) {
// A built shader node (WebGL, Canvas, or the DOM test fake) always has a
// `shaderType`; a raw StyleEffects props object never does. Only convert
// the latter — a built shader is already ready to render.
if (SHADERS_ENABLED && props.shader && !('shaderType' in props.shader)) {
props.shader = Config.convertToShader(node, props.shader);
}

Expand Down Expand Up @@ -1692,7 +1695,7 @@ export class ElementNode {
}
}

if (SHADERS_ENABLED && props.shader && !props.shader.program) {
if (SHADERS_ENABLED && props.shader && !('shaderType' in props.shader)) {
props.shader = Config.convertToShader(node, props.shader);
}

Expand Down
Loading