chore(release): vendor bench from npm at release time - #7
Merged
Conversation
📝 WalkthroughWalkthroughThe release process pins ChangesBench vendoring and release artifacts
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Sequence Diagram(s)sequenceDiagram
participant ReleaseWorkflow
participant VendorScript
participant ReleaseCommit
participant GitHubAPI
ReleaseWorkflow->>VendorScript: run npm run vendor
VendorScript-->>ReleaseWorkflow: generate vendor/Dockerfile and vendor/dist/harness.mjs
ReleaseWorkflow->>ReleaseCommit: build release tree
ReleaseCommit->>GitHubAPI: upload dist and vendor blobs
GitHubAPI-->>ReleaseCommit: create release commit tree
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #6.
vendor/(bench's sandboxDockerfile+ self-containeddist/harness.mjs) leavesmainthe same waydist/already did: regenerated at release time and layered onto the release tag.mainis now fully TypeScript-only.Changes
@soroush.tech/bench@2.1.0(now on npm) as an exact devDependency — re-vendoring becomes "bump the version".scripts/vendor.mjscopies fromnode_modulesdirectly; the published package'sexportsmap doesn't expose./package.json, so the previousrequire.resolveapproach broke against the real npm artifact.scripts/release-commit.mjswalksdist/andvendor/recursively (POSIX tree paths) when assembling the release commit..gitignore/vendor/; committed copies removed.release-notes/1.0.1.md(noaction.ymlcontract change).Verification
--baseline-case,--min-ratio,--md-file); the npm artifact is canonical going forward.node_modules+vendor/, thennpm ci && npm run vendorregenerated everything — the exact path CI and the Release workflow take.v1,v1.0.0) are unaffected; after merge, dispatch the Release workflow for 1.0.1 and verify the tag tree containsdist/index.cjs,vendor/Dockerfile,vendor/dist/harness.mjs.