Skip to content

fix: harden pip shell commands - #126

Open
damacus wants to merge 1 commit into
mainfrom
fix/harden-pip-shell-commands
Open

fix: harden pip shell commands#126
damacus wants to merge 1 commit into
mainfrom
fix/harden-pip-shell-commands

Conversation

@damacus

@damacus damacus commented Jun 8, 2026

Copy link
Copy Markdown
Member

Summary

  • Build pip command lines from argument arrays with Shellwords
  • Split options safely and drop empty mode arguments
  • Escape virtualenv pip executable and package arguments

Verification

  • cookstyle libraries/helpers.rb resources/pip.rb
  • ruby -c libraries/helpers.rb
  • ruby -c resources/pip.rb

Build pip commands with Shellwords and avoid interpolating package properties into shell strings.\n\nVerification:\n- cookstyle libraries/helpers.rb resources/pip.rb\n- ruby -c libraries/helpers.rb\n- ruby -c resources/pip.rb
@damacus
damacus requested a review from a team as a code owner June 8, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant