Skip to content

Fix optional dropdown auto-selecting the first value #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RabbiIslamRony wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Fix optional dropdown auto-selecting the first value #2973

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12a5be9
fix: preserve empty optional dropdown values
RabbiIslamRony Aug 24, 2026
3e6f890
Merge branch 'development' into investigate-ticket-3246
RabbiIslamRony Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions templates/listing-form/custom-fields/select.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,34 @@
/**
* @author wpWax
* @since 6.6
* @version 8.6
* @version 8.9.4
*/

if ( ! defined( 'ABSPATH' ) ) exit;

// Get conditional logic attributes using centralized method
$conditional_logic_attr = $listing_form->get_conditional_logic_attributes( $data );
$options = ! empty( $data['options'] ) && is_array( $data['options'] ) ? $data['options'] : [];
$has_empty_option = in_array( '', wp_list_pluck( $options, 'option_value' ), true );
$show_empty_option = empty( $data['required'] ) && ! $has_empty_option;
$placeholder = ! empty( $data['placeholder'] ) ? $data['placeholder'] : __( 'Select...', 'directorist' );
?>

<div class="directorist-form-group directorist-custom-field-select"<?php echo $conditional_logic_attr; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- Already escaped in get_conditional_logic_attributes() ?>>

<?php $listing_form->field_label_template( $data );?>

<?php if ( ! empty( $data['options'] ) ) : ?>
<?php if ( ! empty( $options ) ) : ?>

<select name="<?php echo esc_attr( $data['field_key'] ); ?>" id="<?php echo esc_attr( $data['field_key'] ); ?>" class="directorist-form-element" <?php $listing_form->required( $data ); ?>>

<?php foreach ( $data['options'] as $key => $value ) : ?>
<?php if ( $show_empty_option ) : ?>

<option value="" <?php selected( '', $data['value'] ); ?>><?php echo esc_html( $placeholder ); ?></option>

<?php endif; ?>

<?php foreach ( $options as $value ) : ?>

<option value="<?php echo esc_attr( $value['option_value'] )?>" <?php selected( $value['option_value'], $data['value'] ); ?>><?php echo esc_attr( $value['option_label'] )?></option>

Expand Down
Loading