Skip to content

Remove live preview label from badge conditions - #2981

Open
RabbiIslamRony wants to merge 2 commits into
sovware:developmentfrom
RabbiIslamRony:remove-custom-badge-preview
Open

Remove live preview label from badge conditions#2981
RabbiIslamRony wants to merge 2 commits into
sovware:developmentfrom
RabbiIslamRony:remove-custom-badge-preview

Conversation

@RabbiIslamRony

Copy link
Copy Markdown
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Security fix
  • Improvement
  • New Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Text changes
  • Other... Please describe:

Description

How to reproduce the issue or how to test the changes

Main issue

The expanded badge condition editor displays a Live preview label beside the match-mode controls, but that area does not provide a separate preview action or preview panel. The label is therefore misleading, particularly while editing a custom badge.

What changed

  • Removed the Live preview label from the badge condition header.
  • Kept badge matching, condition controls, saved rules, and frontend output unchanged.

How to test

  1. Build the legacy admin assets and open Directorist > Settings > Appearance > Badges.
  2. Add or expand a custom badge.
  3. Confirm the Match conditions header shows the All (AND) and Any (OR) controls without the Live preview label.
  4. Add or edit a condition and save the settings; confirm the badge rule still persists normally.

Screenshot reference

The supplied before screenshot highlights the removed Live preview label to the right of the custom badge match-condition controls.

Any linked issues

N/A

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant