Compatibility with sf 8 + behat 4 + mink 3 - #42
Conversation
Jean-Beru
left a comment
Jean-Beru
left a comment
There was a problem hiding this comment.
Thanks for your contribution @julien-maurel. Just 2 comments about BC promise.
| "php": ">=8.0", | ||
| "behat/behat": "^3.0.13", | ||
| "friends-of-behat/mink-extension": "^2.3.1", | ||
| "behat/behat": "^4.0", |
There was a problem hiding this comment.
It's clearly a BC break. This extension couldn't be used with Behat 3.
| trait Html | ||
| { | ||
| abstract protected function getSession($name = null); | ||
| abstract public function getSession(?string $name = null): Session; |
There was a problem hiding this comment.
public function getSession($name = null) should be used to keep compatibility with Mink v2 and v3
@Jean-Beru Yes, I didn't try to keep compatibility with current major versions and incomming ones. |
|
Hey ! I have the exact same usecase as @julien-maurel does. Is it planned to merge this PR, and maybe make a breaking major version of this package to follow behat:4, while keeping compatibility with prior versions in current v3.3.13 ? Thanks for the answer :) |
3 participants
Hi,
We just migrate ours apps to symfony 8 and behat 4, so we do changes about that.
It can be merged as it but I think it might be worth spending a bit more time to have more type hinting.
What do you think ?