G3P-22238: Revert to opt-in privilege model in osThreadNew - #15
Merged
Conversation
Restore the original opt-in check (osThreadPrivileged must be explicitly set) instead of the opt-out inversion. With CREATE_PRIVILEGED_THREAD_ATTRIBUTES setting osThreadPrivileged on all service threads and CREATE_THREAD_ATTRIBUTES leaving it unset for unprivileged tasks, opt-in is the correct and cleaner default.
Author
|
Here's an output from GDB showing the task continuously executing the unprivileged thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
This work supports G3P-22238, which creates an unprivileged FreeRTOS task on STM32H573 (Cortex-M33 with TrustZone). The CMSIS-RTOS2 wrapper previously had no mechanism to create unprivileged tasks via the `osThreadNew` API — all threads were created privileged regardless of the `osThreadUnprivileged` attribute flag.
Test plan
🤖 Generated with Claude Code