Skip to content

G3P-7268: add method to set blocking mode #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
minh-anderson-dojofive wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

G3P-7268: add method to set blocking mode #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ed9a08
Fixing compiler flag for clang/llvm v16
patrick-dojofive Jun 25, 2024
13321ad
G3P-7268: Add method to set non blocking mode for flash memory
Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pw_build/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ pw_add_library_generic(pw_build.pedantic_warnings INTERFACE
"-Wno-gnu-zero-variadic-macro-arguments"

# TODO: b/333712899 - Enable C23 extension warnings.
"-Wno-c23-extensions"
"-Wno-c2x-extensions"

# TODO: b/335021928 - Enable C++ 20 extension warnings.
"-Wno-c++20-extensions"
Expand Down
3 changes: 3 additions & 0 deletions pw_kvs/public/pw_kvs/flash_memory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include "pw_span/span.h"
#include "pw_status/status.h"
#include "pw_status/status_with_size.h"
#include "cmsis_os2.h"

#if PW_CXX_STANDARD_IS_SUPPORTED(17) // Requires C++17 for pw::Result
#include "pw_stream/seek.h"
Expand Down Expand Up @@ -132,6 +133,8 @@ class FlashMemory {
return erased_memory_content_;
}

virtual void SetBlockingMode(bool en_blocking, osThreadId_t task_handle) = 0;

private:
const uint32_t sector_size_;
const uint32_t flash_sector_count_;
Expand Down