Fix Internet Commute rider lifecycle and Slow Mode boarding - #440
Merged
Conversation
commit: |
Owner
Author
Preview evidenceFixes live rider cleanup, Slow Mode boarding, platform cursor placement, and completed-route restart. Open preview · Review all evidence · Commit Waiting on the platformThe local cursor is fully above the yellow platform edge before the train arrives. Open captured page · 1440×1100 Train arrivingThe train pulls in front of the cursor while the cursor remains on the platform side of the yellow edge. Open captured page · 1440×1100 Cursor boardingThe train occludes the cursor at the doorway; no cursor is drawn on the train body or on the track side of the yellow edge. Open captured page · 1440×1100 Published by PR Evidence. Media is temporary and is removed after retention expires. |
Deploying we-were-online-website with
|
| Latest commit: |
bb21a1a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b5594c5a.we-were-online-website.pages.dev |
| Branch Preview URL: | https://cx-commute-presence-boarding.we-were-online-website.pages.dev |
Owner
Author
Code reviewNo issues found. Checked for bugs and project-instruction compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Root cause
The UI used the dispatcher assignment count for live occupancy. Slow Mode also derived its intro from the shared train creation time, so late riders skipped it, while the boarding phase immediately hid the cursor. Completed assignments were refreshed with the same rider token and returned the completed route instead of starting the next trip.
Verification
bun run test:extension(140 files, 903 tests)bun run check:extensionbun run check:extension-websiteRelease notes
Updated
extension/PENDING.md. No extension permissions changed.