Conversation
Add an empty py.typed marker and a setuptools package-data entry so the package advertises its inline type annotations to downstream type checkers per PEP 561.
fametrano
force-pushed
the
electrum-ecc-py-typed
branch
from
September 12, 2026 12:34
ab8f81c to
b24725f
Compare
Contributor
Author
|
@SomberNight the It is a three-line change shipping the |
Contributor
Author
|
@SomberNight |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package ships type annotations but no PEP 561
py.typedmarker, so a downstream mypy user does not see them.This adds an empty
py.typedand declares it as package data, so the marker ships in the wheel (verified by building withELECTRUM_ECC_DONT_COMPILE=1).