Read version from pyproject.toml

[0jc1]

This addresses #103

The function get_version_from_toml() only works for 3.10+. Prior versions do not have a built-in toml reader.

[stevepiercy]

Thanks for this PR! Sorry for the long delay to respond.

The concept is nice, and I have a few suggestions. Would you please take care? Thank you!

[0jc1]

Good suggestions, i applied all of them.

it might be necessary to specify tomli as a dependency in pyproject.toml like this:

[project]
dependencies = [
    'tomli ; python_version < "3.11"'
]

[stevepiercy]

it might be necessary to specify tomli as a dependency in pyproject.toml like this:

[project]
dependencies = [
    'tomli ; python_version < "3.11"'
]

Yes, almost. It should go in the dev dependencies group, since it's not a requirement to use this package, sorted alphabetically:

https://github.com/0jc1/httpdomain/blob/08f79f6833793e5dac4cd90e5d500e5c44bf67a9/pyproject.toml#L60-L67

Also would you please add a change log entry in CHANGES.rst, giving yourself credit for the change?

Thank you!

[read-the-docs-community]

Documentation build overview

📚 sphinxcontrib-httpdomain | 🛠️ Build #34130764 | 📁 Comparing a3b319e against latest (738392e)

  🔍 Preview build  

1 file changed

± index.html

[0jc1]

Thank you for the review! It should be ready to merge now.

[stevepiercy]

Thank you for your contribution. I'll tweak the change log entry, then merge.

[stevepiercy]

Whoops, spoke too soon. When adding or updating a dependency, you need to run make livehtml or any other target that calls uv sync to update the uv.lock file, then commit and push the update. make livehtml should also ensure that the docs build with the correct version. Would you please take care? Thank you!

[0jc1]

I pushed the updated uv.lock after running the make livehtml.

[stevepiercy]

Thank you @0jc1! Let's see if it shows up in the next release.