Skip to content

ci: fix nightly AWS CA certs push and limit to main repo - #7185

Merged
sorindumitru merged 1 commit into
spiffe:mainfrom
samuraixwandering:ci-nightly-aws-ca-certs-fetch-and-fork-guard
Aug 2, 2026
Merged

ci: fix nightly AWS CA certs push and limit to main repo#7185
sorindumitru merged 1 commit into
spiffe:mainfrom
samuraixwandering:ci-nightly-aws-ca-certs-fetch-and-fork-guard

Conversation

@samuraixwandering

Copy link
Copy Markdown
Contributor

Summary

Fixes the nightly update-aws-ca-certs job that has been failing with git push --force-with-lease rejected as stale info.

  1. fetch-depth: 0 on the job checkout so the remote tracking ref for bot/update-aws-ca-certs exists and --force-with-lease can compare against it (default single-branch checkout only has main).
  2. if: github.repository == 'spiffe/spire' so the job does not run on forks.

As discussed on #7184.

Test plan

  • Diff limited to .github/workflows/nightly_build.yaml
  • After merge: nightly (or workflow_dispatch) succeeds at the push step when certs drift
  • On a fork, update-aws-ca-certs is skipped

Fixes #7184

fetch-depth: 0 so force-with-lease has a tracking ref for
bot/update-aws-ca-certs. Restrict the job to spiffe/spire so
forks do not run the updater.

Fixes spiffe#7184

Signed-off-by: samuraiXwandering <301416091+samuraixwandering@users.noreply.github.com>

@sorindumitru sorindumitru left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @samuraixwandering

@sorindumitru sorindumitru added this to the 1.15.3 milestone Aug 2, 2026
@sorindumitru
sorindumitru enabled auto-merge August 2, 2026 08:56
@sorindumitru
sorindumitru added this pull request to the merge queue Aug 2, 2026
Merged via the queue into spiffe:main with commit 8c1b4c9 Aug 2, 2026
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nightly update-aws-ca-certs job has been failing since #6917 landed

2 participants