feat(remote): add an instance type to remote deploys and fleet nodes - #195
Merged
Merged
Conversation
…odes The type is stored on the environment's deploy config and read back on its next fresh launch — a re-wake of a stopped instance keeps the type it launched with. Fed by `remote deploy --instance-type` and a fleet node's `instance-type`; omitted means the control plane's default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
kind: remotenode and a standaloneremote deploycan now name the EC2 instance type the environment's instances launch as, instead of always using the control plane's default.Summary
remote deploy --instance-typeand a fleet node'sinstance-typeboth record the type on the environment's deploy config.instance-typeon akind: daemonnode, or a malformed value anywhere, is rejected with the value named.fleet.yamlandremote deployreference docs, and thefleet-remoteexample are updated.Implementation details
The type is stored on the environment's per-environment deploy config (the SSM parameter the start Lambda reads on each wake) and read back on the next fresh launch. A re-wake of a stopped instance keeps the type it was launched with — EC2 cannot resize an existing instance — so a changed value takes effect only after the instance is terminated (an idle sweep or
remote stop) and launched again. The field is optional and omitted when empty, so an untyped deploy sends exactly what an older control plane expects.Closes #192