Fix FilterExpressionTextParser for keys starting with the where letters - #6912
Open
harrisleesh wants to merge 1 commit into
Open
Fix FilterExpressionTextParser for keys starting with the where letters#6912harrisleesh wants to merge 1 commit into
FilterExpressionTextParser for keys starting with the where letters#6912harrisleesh wants to merge 1 commit into
Conversation
…etters The compulsory WHERE keyword was only prepended when the expression did not start with the letters "where", using a plain string prefix check. A key such as `whereabouts` satisfied that check, so WHERE was never prepended and parsing failed with an InputMismatchException. Only skip prepending when the expression starts with the standalone WHERE keyword. Fixes spring-projects#6909 Signed-off-by: seonghun lee <harrisleesh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
FilterExpressionTextParserprepends the compulsoryWHEREkeyword using a plain string prefix check, so an expression whose first key merely starts with the letterswhere— e.g.whereabouts == 'BG'orwhere_clause == 'BG'— never gets the keyword prepended and fails with anInputMismatchException.Changes
WHEREkeyword (^\s*where\b, case-insensitive), not any identifier starting with those letters.whereaboutsandwhere_clausekeys. It fails onmainand passes with the fix; the fullspring-ai-vector-storemodule test suite passes (163 tests).Fixes #6909